Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80413?usp=email )
Change subject: soc/amd/picasso: Use pcie_gpp_dxio_update_clk_req_config
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80413/comment/024539da_56c9a885 :
PS1, Line 10: Also this brings picasso inline with cezanne, mendocino and phoenix.
would be god to mention that this adds the code to fix up the clock configuration depending on the dxio descriptors, since that's an essential part of what the patch does
https://review.coreboot.org/c/coreboot/+/80413/comment/35363cb2_020e47d2 :
PS1, Line 12: coomon
common
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80413?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ice2e3a5a78359da9a438434c7d4aa1eca878d396
Gerrit-Change-Number: 80413
Gerrit-PatchSet: 1
Gerrit-Owner: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 09 Feb 2024 14:30:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment