Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57104 )
Change subject: libpayload: cbgfx: Clear screen by sequential access
......................................................................
Patch Set 5:
(1 comment)
File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/57104/comment/32eb2237_1eb10846
PS4, Line 637: memset(FB, color & 0xff, fbinfo->y_resolution * bpl);
I think most people cannot identify the difference if we simply use #202020 or #21212121 ... You may quickly test if that would speed up the execution time.
(the
said memcpy() is slower than the 2-for-loop code below (not related to memset in line #637).
Yes I know, but I wonder if memset is much faster then the loops, no matter the old two-for-loop or your new algorithm.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecaff5b6abc24ba4b3859cbc44c0d61b2a90b2d9
Gerrit-Change-Number: 57104
Gerrit-PatchSet: 5
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 04 Oct 2021 08:42:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment