Attention is currently required from: Caveh Jalali, Sumeet R Pawnikar.
Boris Mittelberg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54724 )
Change subject: mb/google/brya: Add two sensors for DPTF functionality
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Q: Do you plan to add "lower" thermal limits, at least on one sensor, so the fan would start spinnin […]
As suggested in b:181271666 comment#45: based on Volteer reference we can start with 40C and 30% (minimal from the fan datasheet):
```
[1] = {
.target = DPTF_TEMP_SENSOR_1,
.thresholds = {
TEMP_PCT(80, 90),
TEMP_PCT(75, 80),
TEMP_PCT(70, 70),
TEMP_PCT(40, 30)}
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc9bd6040c9bb316ec7e314f5e9c937c75cfc95a
Gerrit-Change-Number: 54724
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Fri, 20 Aug 2021 19:07:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Boris Mittelberg
bmbm@google.com
Gerrit-MessageType: comment