Attention is currently required from: Hung-Te Lin, Rui Zhou.
Yu-Ping Wu has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: support TAS2563 audio amp ......................................................................
Patch Set 2:
(6 comments)
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/ea707b5c_5ac69f56?usp... : PS2, Line 56: GERALT_USE_MAX98390 This Kconfig option should be removed from mainboard/google/geralt/Kconfig.
https://review.coreboot.org/c/coreboot/+/83287/comment/e635ac84_62df0ae0?usp... : PS2, Line 7: #include <fw_config.h> Sort
File src/mainboard/google/geralt/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83287/comment/8219001b_f417e056?usp... : PS2, Line 6: One space.
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/cf3b49e2_ffe45756?usp... : PS2, Line 12: #include <fw_config.h> Sort.
https://review.coreboot.org/c/coreboot/+/83287/comment/5490b2ca_321fa673?usp... : PS2, Line 33: { Skip if `CONFIG(GERALT_USE_NAU8318)`.
https://review.coreboot.org/c/coreboot/+/83287/comment/c1fe5476_b78c2cbd?usp... : PS2, Line 39: } : else if `} else if`