Change in coreboot[master]: mb/google/poppy: set detachable system type for nocturne/soraka

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37540 )

Change subject: mb/google/poppy: set detachable system type for nocturne/soraka
......................................................................

mb/google/poppy: set detachable system type for nocturne/soraka

Set the SMBIOS system type to detachable for nocturne and
soraka variants, to allow the OS to correctly process events.

Change-Id: Ie0ee5ea6666542c0bca2c264b2ed2e6135b78658
Signed-off-by: Matt DeVillier 
---
M src/mainboard/google/poppy/Kconfig
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/37540/1

diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index 674fef9..5a621bb 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -181,6 +181,7 @@
    select EXCLUDE_NATIVE_SD_INTERFACE
    select MAINBOARD_HAS_SPI_TPM_CR50
    select NO_FADT_8042
+	select SYSTEM_TYPE_DETACHABLE
    select VARIANT_HAS_CAMERA_ACPI
    select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR

@@ -198,6 +199,7 @@
    def_bool n
    select DRIVERS_I2C_MAX98927
    select NO_FADT_8042
+	select SYSTEM_TYPE_DETACHABLE
    select VARIANT_HAS_CAMERA_ACPI
    select MAINBOARD_HAS_I2C_TPM_CR50

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37540 )

Change subject: mb/google/poppy: set detachable system type for nocturne/soraka
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37540 )

Change subject: mb/google/poppy: set detachable system type for nocturne/soraka
......................................................................

mb/google/poppy: set detachable system type for nocturne/soraka

Set the SMBIOS system type to detachable for nocturne and
soraka variants, to allow the OS to correctly process events.

Change-Id: Ie0ee5ea6666542c0bca2c264b2ed2e6135b78658
Signed-off-by: Matt DeVillier 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37540
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/mainboard/google/poppy/Kconfig
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index 674fef9..5a621bb 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -181,6 +181,7 @@
    select EXCLUDE_NATIVE_SD_INTERFACE
    select MAINBOARD_HAS_SPI_TPM_CR50
    select NO_FADT_8042
+	select SYSTEM_TYPE_DETACHABLE
    select VARIANT_HAS_CAMERA_ACPI
    select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR

@@ -198,6 +199,7 @@
    def_bool n
    select DRIVERS_I2C_MAX98927
    select NO_FADT_8042
+	select SYSTEM_TYPE_DETACHABLE
    select VARIANT_HAS_CAMERA_ACPI
    select MAINBOARD_HAS_I2C_TPM_CR50