Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59816 )
(
13 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/clevo/l140cu: drop System76 EC ......................................................................
mb/clevo/l140cu: drop System76 EC
Drop System76 EC, since the ODM board does not use it. Clevo EC FW support will be added and hooked up cleanly in the follow-up changes.
Change-Id: I06abbde238be6d25842472a6a82159413ab52ef5 Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/59816 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/clevo/cml-u/Kconfig D src/mainboard/clevo/cml-u/acpi/gpe.asl D src/mainboard/clevo/cml-u/acpi/mainboard.asl D src/mainboard/clevo/cml-u/acpi/sleep.asl M src/mainboard/clevo/cml-u/dsdt.asl M src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb 6 files changed, 16 insertions(+), 45 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/clevo/cml-u/Kconfig b/src/mainboard/clevo/cml-u/Kconfig index f557e6e..bd895e2 100644 --- a/src/mainboard/clevo/cml-u/Kconfig +++ b/src/mainboard/clevo/cml-u/Kconfig @@ -20,7 +20,6 @@ config BOARD_CLEVO_L140CU_BASE bool select BOARD_CLEVO_CMLU_COMMON - select EC_SYSTEM76_EC select HAVE_SPD_IN_CBFS
if BOARD_CLEVO_CMLU_COMMON diff --git a/src/mainboard/clevo/cml-u/acpi/gpe.asl b/src/mainboard/clevo/cml-u/acpi/gpe.asl deleted file mode 100644 index c1bc04d..0000000 --- a/src/mainboard/clevo/cml-u/acpi/gpe.asl +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -// GPP_D9 SCI -Method (_L29, 0, Serialized) { - Debug = Concatenate("GPE _L29: ", ToHexString(_SB.PCI0.LPCB.EC0.WFNO)) - If (_SB.PCI0.LPCB.EC0.ECOK) { - If (_SB.PCI0.LPCB.EC0.WFNO == One) { - Notify(_SB.LID0, 0x80) - } - } -} diff --git a/src/mainboard/clevo/cml-u/acpi/mainboard.asl b/src/mainboard/clevo/cml-u/acpi/mainboard.asl deleted file mode 100644 index 416cc5a..0000000 --- a/src/mainboard/clevo/cml-u/acpi/mainboard.asl +++ /dev/null @@ -1,13 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#define EC_GPE_SCI 0x50 /* GPP_E16 */ -#define EC_GPE_SWI 0x29 /* GPP_D9 */ -#include <ec/system76/ec/acpi/ec.asl> - -Scope (_SB) { - #include "sleep.asl" -} - -Scope (_GPE) { - #include "gpe.asl" -} diff --git a/src/mainboard/clevo/cml-u/acpi/sleep.asl b/src/mainboard/clevo/cml-u/acpi/sleep.asl deleted file mode 100644 index 48c50e0..0000000 --- a/src/mainboard/clevo/cml-u/acpi/sleep.asl +++ /dev/null @@ -1,11 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -/* Method called from _PTS prior to enter sleep state */ -Method (MPTS, 1) { - _SB.PCI0.LPCB.EC0.PTS (Arg0) -} - -/* Method called from _WAK prior to wakeup */ -Method (MWAK, 1) { - _SB.PCI0.LPCB.EC0.WAK (Arg0) -} diff --git a/src/mainboard/clevo/cml-u/dsdt.asl b/src/mainboard/clevo/cml-u/dsdt.asl index 203f39e..e7963b2 100644 --- a/src/mainboard/clevo/cml-u/dsdt.asl +++ b/src/mainboard/clevo/cml-u/dsdt.asl @@ -28,6 +28,4 @@ { #include <drivers/pc80/pc/ps2_controller.asl> } - - #include "acpi/mainboard.asl" } diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb b/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb index bfcc046..7385fe1 100644 --- a/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb +++ b/src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb @@ -183,13 +183,6 @@ device pci 1e.2 off end # GSPI #0 device pci 1e.3 off end # GSPI #1 device pci 1f.0 on # LPC Interface - # LPC configuration from lspci -s 1f.0 -xxx - # Address 0x88: Decode 0x68 - 0x6F (EC PM channel) - register "gen1_dec" = "0x00040069" - # Address 0x8C: Decode 0xE00 - 0xEFF (AP/EC command) - register "gen2_dec" = "0x00fc0e01" - # Address 0x90: Decode 0xF00 - 0xFFF (AP/EC debug) - register "gen3_dec" = "0x00fc0f01" chip drivers/pc80/tpm # TPM device pnp 0c31.0 on end end