Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31297
Change subject: vboot: rename VB2_SD_DEV_MODE_ENABLED ......................................................................
vboot: rename VB2_SD_DEV_MODE_ENABLED
Rename VB2_SD_DEV_MODE_ENABLED to VB2_SD_FLAG_DEV_MODE_ENABLED. See CL in CQ-DEPEND for details.
BUG=b:124141368 TEST=Build locally CQ-DEPEND=CL:1460644 BRANCH=none
Change-Id: I298cd3a5026055e439de1ce409e61f1feb24369b Signed-off-by: Joel Kitching kitching@google.com --- M src/security/vboot/vboot_handoff.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/31297/1
diff --git a/src/security/vboot/vboot_handoff.c b/src/security/vboot/vboot_handoff.c index 684b495..884879e 100644 --- a/src/security/vboot/vboot_handoff.c +++ b/src/security/vboot/vboot_handoff.c @@ -71,7 +71,7 @@ *oflags |= VB_INIT_OUT_ENABLE_DISPLAY; *oflags |= VB_INIT_OUT_ENABLE_USB_STORAGE; } - if (vb2_sd->flags & VB2_SD_DEV_MODE_ENABLED) { + if (vb2_sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED) { *oflags |= VB_INIT_OUT_ENABLE_DEVELOPER; *oflags |= VB_INIT_OUT_CLEAR_RAM; *oflags |= VB_INIT_OUT_ENABLE_DISPLAY;
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31297 )
Change subject: vboot: rename VB2_SD_DEV_MODE_ENABLED ......................................................................
Patch Set 1: Code-Review+2
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31297 )
Change subject: vboot: rename VB2_SD_DEV_MODE_ENABLED ......................................................................
Patch Set 1:
Wait for vboot commit and coreboot vboot sub-repo uprev.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31297 )
Change subject: vboot: rename VB2_SD_DEV_MODE_ENABLED ......................................................................
vboot: rename VB2_SD_DEV_MODE_ENABLED
Rename VB2_SD_DEV_MODE_ENABLED to VB2_SD_FLAG_DEV_MODE_ENABLED. See CL in CQ-DEPEND for details.
BUG=b:124141368 TEST=Build locally CQ-DEPEND=CL:1460644 BRANCH=none
Change-Id: I298cd3a5026055e439de1ce409e61f1feb24369b Signed-off-by: Joel Kitching kitching@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31297 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Julius Werner jwerner@chromium.org --- M src/security/vboot/vboot_handoff.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/src/security/vboot/vboot_handoff.c b/src/security/vboot/vboot_handoff.c index 5ed5011..e846414 100644 --- a/src/security/vboot/vboot_handoff.c +++ b/src/security/vboot/vboot_handoff.c @@ -70,7 +70,7 @@ *oflags |= VB_INIT_OUT_ENABLE_DISPLAY; *oflags |= VB_INIT_OUT_ENABLE_USB_STORAGE; } - if (vb2_sd->flags & VB2_SD_DEV_MODE_ENABLED) { + if (vb2_sd->flags & VB2_SD_FLAG_DEV_MODE_ENABLED) { *oflags |= VB_INIT_OUT_ENABLE_DEVELOPER; *oflags |= VB_INIT_OUT_CLEAR_RAM; *oflags |= VB_INIT_OUT_ENABLE_DISPLAY;
-
Joel Kitching (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)