Attention is currently required from: Arthur Heymans, Michael Niewöhner, Paul Menzel.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80727?usp=email )
Change subject: include/device/azalia_device.h: Correct location2 shift to 28 bits
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80727/comment/69891b19_171c0f56 :
PS2, Line 7: include/device/azalia_device.h: Fix incorrect bit shift
please add Intel HDA Specification as reference (Rev. 1. […]
Done
https://review.coreboot.org/c/coreboot/+/80727/comment/07e7c8e5_7f1c04a7 :
PS2, Line 7: Fix incorrect bit shift
Maybe more specific: […]
Done
https://review.coreboot.org/c/coreboot/+/80727/comment/5bfa90ea_e9355cf1 :
PS2, Line 8:
Please mention the source, that this is the correct value.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80727?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia5a3431b70783cb88e866d0fd8ea5530100f3d52
Gerrit-Change-Number: 80727
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Fri, 23 Feb 2024 23:50:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment