Attention is currently required from: Tarun Tuli, Eran Mitrani, Subrata Banik, Reka Norman, Nick Vaccaro.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70262 )
Change subject: drivers/wifi/generic: Fix properties in generic-under-PCI device case
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/70262/comment/41172b3c_3aceee56
PS4, Line 585: wifi_pcie_fill_ssdt
You might just need something like CB:67566 for ADL-P.
Correct but this is an attempt to fix an issue with the existing code where wifi/generic can handle an integrated WiFi (CNVi) device as a PCIe WiFi device and a Generic device (refer to wifi_generic_enable()).
I have verified this patch for both the cases. Refer to SSDT snippet at the end of the commit message ("SSDT when CNVi").
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70262
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f7d0b826ce067b40fa89d74f421d7018ecc3fbb
Gerrit-Change-Number: 70262
Gerrit-PatchSet: 4
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Mon, 05 Dec 2022 07:11:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Gerrit-MessageType: comment