Attention is currently required from: John Su, Martin L Roth, Jason Nien, Jon Murphy, Jason Glenesk, Chris Wang, Martin Roth, Karthik Ramasubramanian, Felix Held.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74583 )
Change subject: mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/skyrim/variants/markarth/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/74583/comment/3804eb9a_8c2f9178
PS3, Line 88: if (gpio_get(EMMC_CLKREQ_GPIO)) {
Great. Thank you Karthik. […]
Deferring the refactor sounds good to me.
Do we know if Whiterun needs the change also? Or we're skipping it since the SSDs for it to be behaving correctly so far?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74583
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a9225473a6ae1ba01dc8e5d982c4999f073267e
Gerrit-Change-Number: 74583
Gerrit-PatchSet: 3
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chao Gui
chaogui@google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Huang
patrick.huang@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-CC: Tim Van Patten
timvp@google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 20 Apr 2023 23:20:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment