Change in ...coreboot[master]: soc/amd/picasso: Rename makefile.inc back to Makefile.inc

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Martin Roth (Code Review)

23 Apr 2019 23 Apr '19

5:01 p.m.

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32411

Change subject: soc/amd/picasso: Rename makefile.inc back to Makefile.inc ......................................................................

soc/amd/picasso: Rename makefile.inc back to Makefile.inc

Now that the Makefile is updated, we can change the name back without it affecting the Stoney build.

TEST=None BUG=b:130804851

Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I18ee48865fb64265f38179560265827783d50820 --- R src/soc/amd/picasso/Makefile.inc 1 file changed, 0 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/32411/1

diff --git a/src/soc/amd/picasso/makefile.inc b/src/soc/amd/picasso/Makefile.inc similarity index 100% rename from src/soc/amd/picasso/makefile.inc rename to src/soc/amd/picasso/Makefile.inc

Attachments:

attachment.htm (text/html — 2.1 KB)

Show replies by date

Paul Menzel (Code Review)

24 Apr 24 Apr

12:41 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32411 )

Change subject: soc/amd/picasso: Rename makefile.inc back to Makefile.inc ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18ee48865fb64265f38179560265827783d50820 Gerrit-Change-Number: 32411 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Apr 2019 10:41:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Marshall Dawson (Code Review)

25 Jun 25 Jun

2:02 a.m.

Marshall Dawson has uploaded a new patch set (#2) to the change originally created by Martin Roth. ( https://review.coreboot.org/c/coreboot/+/32411 )

Change subject: soc/amd/picasso: Rename makefile.inc back to Makefile.inc ......................................................................

soc/amd/picasso: Rename makefile.inc back to Makefile.inc

Now that the Makefile is updated, we can change the name back without it affecting the Stoney build.

TEST=None BUG=b:130804851

Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I18ee48865fb64265f38179560265827783d50820 --- R src/soc/amd/picasso/Makefile.inc 1 file changed, 0 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/32411/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18ee48865fb64265f38179560265827783d50820 Gerrit-Change-Number: 32411 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Richard Spiegel (Code Review)

2 Jul 2 Jul

2 a.m.

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32411 )

Change subject: soc/amd/picasso: Rename makefile.inc back to Makefile.inc ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18ee48865fb64265f38179560265827783d50820 Gerrit-Change-Number: 32411 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 02 Jul 2019 00:00:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Edward O'Callaghan (Code Review)

4:28 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32411 )

Change subject: soc/amd/picasso: Rename makefile.inc back to Makefile.inc ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18ee48865fb64265f38179560265827783d50820 Gerrit-Change-Number: 32411 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 02 Jul 2019 02:28:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

3:26 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32411 )

Change subject: soc/amd/picasso: Rename makefile.inc back to Makefile.inc ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18ee48865fb64265f38179560265827783d50820 Gerrit-Change-Number: 32411 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 02 Jul 2019 13:26:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

4:32 p.m.

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32411 )

Change subject: soc/amd/picasso: Rename makefile.inc back to Makefile.inc ......................................................................

soc/amd/picasso: Rename makefile.inc back to Makefile.inc

Now that the Makefile is updated, we can change the name back without it affecting the Stoney build.

TEST=None BUG=b:130804851

Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I18ee48865fb64265f38179560265827783d50820 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32411 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Richard Spiegel richard.spiegel@silverbackltd.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- R src/soc/amd/picasso/Makefile.inc 1 file changed, 0 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, but someone else must approve Richard Spiegel: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved

diff --git a/src/soc/amd/picasso/makefile.inc b/src/soc/amd/picasso/Makefile.inc similarity index 100% rename from src/soc/amd/picasso/makefile.inc rename to src/soc/amd/picasso/Makefile.inc

-- To view, visit https://review.coreboot.org/c/coreboot/+/32411 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18ee48865fb64265f38179560265827783d50820 Gerrit-Change-Number: 32411 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1971

days inactive

2041

days old

coreboot-gerrit@coreboot.org

6 comments

6 participants

tags (0)

participants (6)

Edward O'Callaghan (Code Review)
HAOUAS Elyes (Code Review)
Marshall Dawson (Code Review)
Martin Roth (Code Review)
Paul Menzel (Code Review)
Richard Spiegel (Code Review)