Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74515 )
Change subject: mb/google,intel,samsung: Use common poweroff() ......................................................................
mb/google,intel,samsung: Use common poweroff()
Change-Id: I3881c152663a038833d8126d7f24f2a6688426d1 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/google/parrot/smihandler.c M src/mainboard/google/stout/smihandler.c M src/mainboard/samsung/lumpy/smihandler.c 3 files changed, 17 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/74515/1
diff --git a/src/mainboard/google/parrot/smihandler.c b/src/mainboard/google/parrot/smihandler.c index 05f14af..8d54dec 100644 --- a/src/mainboard/google/parrot/smihandler.c +++ b/src/mainboard/google/parrot/smihandler.c @@ -2,11 +2,10 @@
#include <console/console.h> #include <cpu/x86/smm.h> +#include <halt.h> #include <soc/nvs.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/bd82x6x/me.h> -#include <southbridge/intel/common/pmutil.h> -#include <southbridge/intel/common/pmbase.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <ec/compal/ene932/ec.h> #include "ec.h" @@ -26,7 +25,7 @@ printk(BIOS_DEBUG, "LID CLOSED, SHUTDOWN\n");
/* Go to S5 */ - write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10)); + poweroff(); break; }
@@ -42,7 +41,7 @@ printk(BIOS_DEBUG, "LID CLOSED, SHUTDOWN\n");
/* Go to S5 */ - write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10)); + poweroff(); } }
diff --git a/src/mainboard/google/stout/smihandler.c b/src/mainboard/google/stout/smihandler.c index f6adbf9..30637ab 100644 --- a/src/mainboard/google/stout/smihandler.c +++ b/src/mainboard/google/stout/smihandler.c @@ -3,10 +3,10 @@ #include <device/pci_ops.h> #include <console/console.h> #include <cpu/x86/smm.h> +#include <halt.h> #include <soc/nvs.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/bd82x6x/me.h> -#include <southbridge/intel/common/pmbase.h> #include <northbridge/intel/sandybridge/sandybridge.h>
/* Include EC functions */ @@ -21,7 +21,7 @@ case EC_SMI_LID_CLOSED: printk(BIOS_DEBUG, "LID CLOSED, SHUTDOWN\n"); /* Go to S5 */ - write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10)); + poweroff(); break; }
diff --git a/src/mainboard/samsung/lumpy/smihandler.c b/src/mainboard/samsung/lumpy/smihandler.c index 1c7d626..d6c8978 100644 --- a/src/mainboard/samsung/lumpy/smihandler.c +++ b/src/mainboard/samsung/lumpy/smihandler.c @@ -2,9 +2,9 @@
#include <console/console.h> #include <cpu/x86/smm.h> +#include <halt.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/bd82x6x/me.h> -#include <southbridge/intel/common/pmbase.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <ec/smsc/mec1308/ec.h> #include "ec.h" @@ -20,7 +20,7 @@ printk(BIOS_DEBUG, "LID CLOSED, SHUTDOWN\n");
/* Go to S5 */ - write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10)); + poweroff(); break; }