Attention is currently required from: Karthik Ramasubramanian, Kun Liu, Subrata Banik, Wentao Qin.
Eric Lai has posted comments on this change by Wentao Qin. ( https://review.coreboot.org/c/coreboot/+/83323?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: brox/var/lotso: Select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83323/comment/48752ebd_7a993dcd?usp... :
PS2, Line 7: brox/var/lotso: Select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS
mb/google/brox/var/lotso: please remember the rule.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83323?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2fbcc7ffaabf3c085a3345ec94a8d45b225b3450
Gerrit-Change-Number: 83323
Gerrit-PatchSet: 2
Gerrit-Owner: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Fri, 05 Jul 2024 02:08:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes