Hello Bob Moragues,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/45276
to review the following change.
Change subject: [WIP] strongbad / coachz : Add Initial Support ......................................................................
[WIP] strongbad / coachz : Add Initial Support
BUG=b:162409909 BUG=b:164196066 BRANCH=NONE TEST=Verify build of strongbad target
Signed-off-by: Bob Moragues moragues@chromium.org Change-Id: If83bd2c8f25fdd3c9625f40121e55c3c922a66fe --- M Documentation/security/vboot/list_vboot.md M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/trogdor/Kconfig.name 3 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/45276/1
diff --git a/Documentation/security/vboot/list_vboot.md b/Documentation/security/vboot/list_vboot.md index 845c0e7..30083f0 100644 --- a/Documentation/security/vboot/list_vboot.md +++ b/Documentation/security/vboot/list_vboot.md @@ -142,6 +142,7 @@ - Trogdor - Lazor - Bubs +- Coachz - Veyron_Jaq (Haier Chromebook 11) - Veyron_Jerry (Hisense Chromebook 11) - Veyron_Mighty (Haier Chromebook 11(edu)) diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig index 6a0f912..5925697 100644 --- a/src/mainboard/google/trogdor/Kconfig +++ b/src/mainboard/google/trogdor/Kconfig @@ -51,6 +51,7 @@ config MAINBOARD_PART_NUMBER string default "Bubs" if BOARD_GOOGLE_BUBS + default "Coachz" if BOARD_GOOGLE_COACHZ default "Lazor" if BOARD_GOOGLE_LAZOR default "Pompom" if BOARD_GOOGLE_POMPOM default "Trogdor" if BOARD_GOOGLE_TROGDOR diff --git a/src/mainboard/google/trogdor/Kconfig.name b/src/mainboard/google/trogdor/Kconfig.name index b7c03f9..ea12307 100644 --- a/src/mainboard/google/trogdor/Kconfig.name +++ b/src/mainboard/google/trogdor/Kconfig.name @@ -4,6 +4,10 @@ bool "Bubs" select BOARD_GOOGLE_TROGDOR_COMMON
+config BOARD_GOOGLE_COACHZ + bool "Coachz" + select BOARD_GOOGLE_TROGDOR_COMMON + config BOARD_GOOGLE_LAZOR bool "Lazor" select BOARD_GOOGLE_TROGDOR_COMMON
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45276 )
Change subject: [WIP] strongbad / coachz : Add Initial Support ......................................................................
Patch Set 1:
LGTM but please take out the [WIP] tag.
Hello build bot (Jenkins), Philip Chen, Bob Moragues, Julius Werner, Wai-Hong Tam,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45276
to look at the new patch set (#2).
Change subject: strongbad / coachz : Add Initial Support ......................................................................
strongbad / coachz : Add Initial Support
BUG=b:162409909 BUG=b:164196066 BRANCH=NONE TEST=Verify build of strongbad target
Signed-off-by: Bob Moragues moragues@chromium.org Change-Id: If83bd2c8f25fdd3c9625f40121e55c3c922a66fe --- M Documentation/security/vboot/list_vboot.md M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/trogdor/Kconfig.name 3 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/45276/2
Bob Moragues has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45276 )
Change subject: strongbad / coachz : Add Initial Support ......................................................................
Patch Set 2:
Patch Set 1:
LGTM but please take out the [WIP] tag.
Done
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45276 )
Change subject: strongbad / coachz : Add Initial Support ......................................................................
Patch Set 2: Code-Review+2
Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45276 )
Change subject: strongbad / coachz : Add Initial Support ......................................................................
strongbad / coachz : Add Initial Support
BUG=b:162409909 BUG=b:164196066 BRANCH=NONE TEST=Verify build of strongbad target
Signed-off-by: Bob Moragues moragues@chromium.org Change-Id: If83bd2c8f25fdd3c9625f40121e55c3c922a66fe Reviewed-on: https://review.coreboot.org/c/coreboot/+/45276 Reviewed-by: Julius Werner jwerner@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/security/vboot/list_vboot.md M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/trogdor/Kconfig.name 3 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/Documentation/security/vboot/list_vboot.md b/Documentation/security/vboot/list_vboot.md index 845c0e7..30083f0 100644 --- a/Documentation/security/vboot/list_vboot.md +++ b/Documentation/security/vboot/list_vboot.md @@ -142,6 +142,7 @@ - Trogdor - Lazor - Bubs +- Coachz - Veyron_Jaq (Haier Chromebook 11) - Veyron_Jerry (Hisense Chromebook 11) - Veyron_Mighty (Haier Chromebook 11(edu)) diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig index e0f071c..b3ec4b5 100644 --- a/src/mainboard/google/trogdor/Kconfig +++ b/src/mainboard/google/trogdor/Kconfig @@ -52,6 +52,7 @@ config MAINBOARD_PART_NUMBER string default "Bubs" if BOARD_GOOGLE_BUBS + default "Coachz" if BOARD_GOOGLE_COACHZ default "Lazor" if BOARD_GOOGLE_LAZOR default "Pompom" if BOARD_GOOGLE_POMPOM default "Trogdor" if BOARD_GOOGLE_TROGDOR diff --git a/src/mainboard/google/trogdor/Kconfig.name b/src/mainboard/google/trogdor/Kconfig.name index b7c03f9..ea12307 100644 --- a/src/mainboard/google/trogdor/Kconfig.name +++ b/src/mainboard/google/trogdor/Kconfig.name @@ -4,6 +4,10 @@ bool "Bubs" select BOARD_GOOGLE_TROGDOR_COMMON
+config BOARD_GOOGLE_COACHZ + bool "Coachz" + select BOARD_GOOGLE_TROGDOR_COMMON + config BOARD_GOOGLE_LAZOR bool "Lazor" select BOARD_GOOGLE_TROGDOR_COMMON
-
Bob Moragues (Code Review) -
Julius Werner (Code Review)