Change in coreboot[master]: mb/google/zork: Set GPIO 86 high on boot

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47673 )

Change subject: mb/google/zork: Set GPIO 86 high on boot
......................................................................

mb/google/zork: Set GPIO 86 high on boot

GPIO 86 should be set high on boot to save power.

BUG=b:173340497
TEST=Build only
BRANCH=Zork

Signed-off-by: Martin Roth 
Change-Id: I31ef1d2a1967d82ba5370462783a909417088d2f
---
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/47673/1

diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
index e43ccdd..884862d 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
@@ -97,8 +97,8 @@
    PAD_GPI(GPIO_84, PULL_NONE),
    /* APU_EDP_BL_DISABLE TODP: Set low in depthcharge */
    PAD_GPO(GPIO_85, HIGH),
-	/* RAM ID 2 */
-	PAD_GPI(GPIO_86, PULL_NONE),
+	/* RAM ID 2 - Keep High */
+	PAD_GPO(GPIO_86, HIGH),
    /* EMMC_DATA7 */
    PAD_NF(GPIO_87, EMMC_DATA7, PULL_NONE),
    /* EMMC_DATA5 */

[Rob Barnes (Code Review)]

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47673 )

Change subject: mb/google/zork: Set GPIO 86 high on boot
......................................................................

Patch Set 1: Code-Review+2

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47673 )

Change subject: mb/google/zork: Set GPIO 86 high on boot
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47673 )

Change subject: mb/google/zork: Set GPIO 86 high on boot
......................................................................

mb/google/zork: Set GPIO 86 high on boot

GPIO 86 should be set high on boot to save power.

BUG=b:173340497
TEST=Build only
BRANCH=Zork

Signed-off-by: Martin Roth 
Change-Id: I31ef1d2a1967d82ba5370462783a909417088d2f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47673
Tested-by: build bot (Jenkins) 
Reviewed-by: Rob Barnes 
Reviewed-by: Marshall Dawson 
---
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Marshall Dawson: Looks good to me, approved
  Rob Barnes: Looks good to me, approved

diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
index e43ccdd..884862d 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
@@ -97,8 +97,8 @@
    PAD_GPI(GPIO_84, PULL_NONE),
    /* APU_EDP_BL_DISABLE TODP: Set low in depthcharge */
    PAD_GPO(GPIO_85, HIGH),
-	/* RAM ID 2 */
-	PAD_GPI(GPIO_86, PULL_NONE),
+	/* RAM ID 2 - Keep High */
+	PAD_GPO(GPIO_86, HIGH),
    /* EMMC_DATA7 */
    PAD_NF(GPIO_87, EMMC_DATA7, PULL_NONE),
    /* EMMC_DATA5 */