Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60209
to look at the new patch set (#3).
Change subject: soc/amd/common/lpc/espi_util: handle espi_get_configuration error ......................................................................
soc/amd/common/lpc/espi_util: handle espi_get_configuration error
In espi_wait_channel_ready the return value of espi_get_configuration didn't get checked before. In the case of the espi_send_command call in espi_get_configuration returning CB_ERR, espi_get_configuration didn't write to the local config variable, so if this happens in the first pass of the do-while loop, the following espi_slave_is_channel_ready call would use the uninitialized local config variable as parameter. Fix this by checking the return value of espi_get_configuration.
TEST=None
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Iff1a0670e17b9d6c6f4daf2ea56badf6c428b8c9 --- M src/soc/amd/common/block/lpc/espi_util.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/60209/3