Attention is currently required from: Raul Rangel, Rob Barnes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61612 )
Change subject: mb/google/guybrush: Enable CONSOLE_CBMEM_DUMP_TO_UART
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/61612/comment/e7d73bef_41179012
PS1, Line 15: !CONSOLE_SERIAL
IS this needed? I see CBMEM_DUMP_TO_UART already depends on !CONSOLE_SERIAL.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61612
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I908037527206cc7bed2302fab60b2912d6dabc73
Gerrit-Change-Number: 61612
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Tue, 08 Feb 2022 00:28:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment