Attention is currently required from: Arthur Heymans.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63057 )
Change subject: device/dram/common.h: Use C over CPP
......................................................................
Patch Set 1:
(1 comment)
File src/include/device/dram/common.h:
https://review.coreboot.org/c/coreboot/+/63057/comment/9e9ea936_5d8fba45
PS1, Line 47: ;
You generally don't want the semicolon to be part of the macro.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8511ab46184aa0d8ee3a79c3ef22614aeb61298
Gerrit-Change-Number: 63057
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 23 Mar 2022 23:16:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment