Change in coreboot[master]: soc/amd/common: Move lpc_util to verstage_x86

List overview All Threads
Download

newer

older

Change in coreboot[master]: [WIP]...

Change in em100[master]: trace:...

Kyösti Mälkki (Code Review)

9 Jul 2020 9 Jul '20

6:10 p.m.

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43328 )

Change subject: soc/amd/common: Move lpc_util to verstage_x86 ......................................................................

soc/amd/common: Move lpc_util to verstage_x86

The file seems to be all about PCI configuration access.

Change-Id: I1e64d3d7df3caa33ee92961fe7246d03f2707ab4 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/amd/common/block/lpc/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43328/1

diff --git a/src/soc/amd/common/block/lpc/Makefile.inc b/src/soc/amd/common/block/lpc/Makefile.inc index 7db176b..b55004c 100644 --- a/src/soc/amd/common/block/lpc/Makefile.inc +++ b/src/soc/amd/common/block/lpc/Makefile.inc @@ -1,7 +1,7 @@ ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_LPC) += lpc.c

bootblock-$(CONFIG_SOC_AMD_COMMON_BLOCK_LPC) += lpc_util.c -verstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_LPC) += lpc_util.c +verstage_x86-$(CONFIG_SOC_AMD_COMMON_BLOCK_LPC) += lpc_util.c romstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_LPC) += lpc_util.c postcar-$(CONFIG_SOC_AMD_COMMON_BLOCK_LPC) += lpc_util.c ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_LPC) += lpc_util.c

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Raul Rangel (Code Review)

10 Jul 10 Jul

9:42 p.m.

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43328 )

Change subject: soc/amd/common: Move lpc_util to verstage_x86 ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e64d3d7df3caa33ee92961fe7246d03f2707ab4 Gerrit-Change-Number: 43328 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 10 Jul 2020 21:42:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

11 Jul 11 Jul

7:49 a.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43328 )

Change subject: soc/amd/common: Move lpc_util to verstage_x86 ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43328/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43328/1//COMMIT_MSG@9 PS1, Line 9: The file seems to be all about PCI configuration access. Rebase on CB:43307 once it is fixed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e64d3d7df3caa33ee92961fe7246d03f2707ab4 Gerrit-Change-Number: 43328 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 11 Jul 2020 07:49:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

12 Jul 12 Jul

10:02 a.m.

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43328 )

Change subject: soc/amd/common: Move lpc_util to verstage_x86 ......................................................................

Abandoned

Kyösti Mälkki (Code Review)

12 Dec 12 Dec

6:41 a.m.

Kyösti Mälkki has restored this change. ( https://review.coreboot.org/c/coreboot/+/43328 )

Change subject: soc/amd/common: Move lpc_util to verstage_x86 ......................................................................

Restored

Kyösti Mälkki (Code Review)

6:42 a.m.

Hello build bot (Jenkins), Raul Rangel, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43328

to look at the new patch set (#2).

Change subject: soc/amd/common: Move lpc_util to verstage_x86 ......................................................................

soc/amd/common: Move lpc_util to verstage_x86

The file seems to be all about PCI configuration access.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/43328/2

Felix Held (Code Review)

15 Dec 15 Dec

7:32 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43328 )

Change subject: soc/amd/common: Move lpc_util to verstage_x86 ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e64d3d7df3caa33ee92961fe7246d03f2707ab4 Gerrit-Change-Number: 43328 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Dec 2020 19:32:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

7:32 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43328 )

Change subject: soc/amd/common: Move lpc_util to verstage_x86 ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43328/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43328/1//COMMIT_MSG@9 PS1, Line 9: The file seems to be all about PCI configuration access.

...

Rebase on CB:43307 once it is fixed.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e64d3d7df3caa33ee92961fe7246d03f2707ab4 Gerrit-Change-Number: 43328 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Dec 2020 19:32:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: comment

Felix Held (Code Review)

7:32 p.m.

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43328 )

Change subject: soc/amd/common: Move lpc_util to verstage_x86 ......................................................................

soc/amd/common: Move lpc_util to verstage_x86

The file seems to be all about PCI configuration access.

Change-Id: I1e64d3d7df3caa33ee92961fe7246d03f2707ab4 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43328 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/lpc/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved

diff --git a/src/soc/amd/common/block/lpc/Makefile.inc b/src/soc/amd/common/block/lpc/Makefile.inc index 68e528f..4fbc061 100644 --- a/src/soc/amd/common/block/lpc/Makefile.inc +++ b/src/soc/amd/common/block/lpc/Makefile.inc @@ -3,7 +3,7 @@ ramstage-y += lpc.c

bootblock-y += lpc_util.c -verstage-y += lpc_util.c +verstage_x86-y += lpc_util.c romstage-y += lpc_util.c postcar-y += lpc_util.c ramstage-y += lpc_util.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/43328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e64d3d7df3caa33ee92961fe7246d03f2707ab4 Gerrit-Change-Number: 43328 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1250

days inactive

1409

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

Felix Held (Code Review)
Kyösti Mälkki (Code Review)
Raul Rangel (Code Review)