Attention is currently required from: Eric Lai, Felix Singer, Jan Samek, Sean Rhodes, Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75820?usp=email )
Change subject: soc/intel/apollolake: Fix FSP SATA speed limit configuraion
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
why not ask FSP to fix
I'm afraid Intel will not fix anything for Apollo Lake anymore unless it's security relevant.
File src/soc/intel/apollolake/include/soc/ahci.h:
https://review.coreboot.org/c/coreboot/+/75820/comment/ed98c446_dd39ba4c :
PS5, Line 12:
extra space
It's a bit field inside AHCI_CAP register, so most other header files mark this with an extra space.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75820?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f55f40941fa618e7de13a5cefe9e17ae34c5c99
Gerrit-Change-Number: 75820
Gerrit-PatchSet: 5
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Jan Samek
jan.samek@siemens.com
Gerrit-Comment-Date: Thu, 15 Jun 2023 09:04:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment