Change in ...coreboot[master]: Little bit more helpful, giving back the lines for each file if any
Balázs Vinarz has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30988
Change subject: Little bit more helpful, giving back the lines for each file if any ......................................................................
Little bit more helpful, giving back the lines for each file if any
Change-Id: I8ae13f62c6e2cd87278fefab8de5faf0d1bc0a90 --- M util/lint/lint-stable-003-whitespace 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/30988/1
diff --git a/util/lint/lint-stable-003-whitespace b/util/lint/lint-stable-003-whitespace index f9b7891..b2011e7 100755 --- a/util/lint/lint-stable-003-whitespace +++ b/util/lint/lint-stable-003-whitespace @@ -20,7 +20,7 @@
# shellcheck disable=SC2086,SC2046 if uname | grep -qi "linux"; then - grep -l "[[:space:]][[:space:]]*$" \ + grep -n -H "[[:space:]][[:space:]]*$" \ $(git ls-files $INCLUDELIST | \ grep -Ev "($EXCLUDELIST)" ) | \ sed -e "s,^.*$,File & has lines ending with whitespace.,"
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30988 )
Change subject: Little bit more helpful, giving back the lines for each file if any ......................................................................
Patch Set 1:
No Signed-off-by line in commit message
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30988
to look at the new patch set (#2).
Change subject: Little bit more helpful, giving back the lines for each file if any ......................................................................
Little bit more helpful, giving back the lines for each file if any
Change-Id: I8ae13f62c6e2cd87278fefab8de5faf0d1bc0a90 Signed-off-by: Balazs Vinarz vinibali1@gmail.com --- M util/lint/lint-stable-003-whitespace 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/30988/2
Balázs Vinarz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30988 )
Change subject: Little bit more helpful, giving back the lines for each file if any ......................................................................
Patch Set 2:
Patch Set 1:
No Signed-off-by line in commit message
sorry, I couldn't manage to sign the commit without editing the patchset. Is there any practice for it?
Balázs Vinarz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30988 )
Change subject: Little bit more helpful, giving back the lines for each file if any ......................................................................
Patch Set 2:
Can we merged this soon?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30988 )
Change subject: Little bit more helpful, giving back the lines for each file if any ......................................................................
Patch Set 2:
Patch Set 2: Is there any practice for it?
It's normal that this is an edit. For future reference, "git commit -s" automatically adds the Signed-off-by line with your configured email address.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30988 )
Change subject: Little bit more helpful, giving back the lines for each file if any ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30988/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30988/2//COMMIT_MSG@7 PS2, Line 7: Little bit more helpful, giving back the lines for each file if any Our commit message style would propose something like:
util/lint: list files with whitespace issues
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30988
to look at the new patch set (#3).
Change subject: util/lint: list files with whitespace issues ......................................................................
util/lint: list files with whitespace issues
Change-Id: I8ae13f62c6e2cd87278fefab8de5faf0d1bc0a90 Signed-off-by: Balazs Vinarz vinibali1@gmail.com --- M util/lint/lint-stable-003-whitespace 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/30988/3
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30988 )
Change subject: util/lint: list files with whitespace issues ......................................................................
Patch Set 3: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30988 )
Change subject: util/lint: list files with whitespace issues ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30988 )
Change subject: util/lint: list files with whitespace issues ......................................................................
util/lint: list files with whitespace issues
Change-Id: I8ae13f62c6e2cd87278fefab8de5faf0d1bc0a90 Signed-off-by: Balazs Vinarz vinibali1@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/30988 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/lint/lint-stable-003-whitespace 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/lint/lint-stable-003-whitespace b/util/lint/lint-stable-003-whitespace index f9b7891..b2011e7 100755 --- a/util/lint/lint-stable-003-whitespace +++ b/util/lint/lint-stable-003-whitespace @@ -20,7 +20,7 @@
# shellcheck disable=SC2086,SC2046 if uname | grep -qi "linux"; then - grep -l "[[:space:]][[:space:]]*$" \ + grep -n -H "[[:space:]][[:space:]]*$" \ $(git ls-files $INCLUDELIST | \ grep -Ev "($EXCLUDELIST)" ) | \ sed -e "s,^.*$,File & has lines ending with whitespace.,"
-
Angel Pons (Code Review) -
Balázs Vinarz (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)