the following patch was just integrated into master: commit dbd006b0820098ab1bc042a16853db7131cf91af Author: Gabe Black firstname.lastname@example.org Date: Thu Feb 20 23:38:49 2014 -0800
cbfstool: Propogate compression errors back to the caller.
When compression fails for whatever reason, the caller should know about it rather than blindly assuming it worked correctly. That can prevent half compressed data from ending up in the image.
This is currently happening for a segment of depthcharge which is triggering a failure in LZMA. The size of the "compressed" data is never set and is recorded as zero, and that segment effectively isn't loaded during boot.
Change-Id: Idbff01f5413d030bbf5382712780bbd0b9e83bc7 Signed-off-by: Gabe Black email@example.com Reviewed-on: https://chromium-review.googlesource.com/187364 Reviewed-by: Hung-Te Lin firstname.lastname@example.org Tested-by: Gabe Black email@example.com Commit-Queue: Gabe Black firstname.lastname@example.org (cherry picked from commit be48f3e41eaf0eaf6686c61c439095fc56883cec) Signed-off-by: Isaac Christensen email@example.com Reviewed-on: http://review.coreboot.org/6960 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich firstname.lastname@example.org Reviewed-by: Paul Menzel email@example.com
See http://review.coreboot.org/6960 for details.