Attention is currently required from: V sujith kumar Reddy, Raul Rangel, Rob Barnes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60314 )
Change subject: Pass the EN_SPKR gpio in devicetree for guybrush
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Is
File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/60314/comment/b3d6e4a7_d7ca08d7
PS2, Line 328: GPIO_31
Pass GPIO_70 in the baseboard devicetree since that will apply to both Nipperkin and Dewatt.
Override it as GPIO_31 in just guybrush overridetree.cb. This will minimize the number of changes required.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60314
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00e433e48cd7ac157163ed9e49c3aa8dc6a850c6
Gerrit-Change-Number: 60314
Gerrit-PatchSet: 2
Gerrit-Owner: V sujith kumar Reddy
vsujithkumar.reddy@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Yu-hsuan Hsu
yuhsuan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: V sujith kumar Reddy
vsujithkumar.reddy@amd.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Mon, 31 Jan 2022 04:21:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment