Attention is currently required from: Felix Singer, Jérémy Compostella, Shuo Liu.
yuchi.chen@intel.com has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83320?usp=email )
Change subject: soc/intel/common/block/imc: Add Integrated Memory Controller driver ......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83320/comment/6b4adccc_fa25a41f?usp... : PS2, Line 7: src/
Remove "src"
Done
File src/soc/intel/common/block/imc/Kconfig:
https://review.coreboot.org/c/coreboot/+/83320/comment/2c550d27_6cc718ca?usp... : PS3, Line 4: bool
There was an imc.h, but seems no one is using it. soc/intel/common/block/include/intelblocks/imc.h. […]
IMC is originally added by commit f377fafd941a44252c4c7527ba08f798d222e7ff to support Intel Xeon Processor D-1500 Product Family and removed, maybe you can check it with your team.
I'm also not sure whether it's general enough to be in common block, I just want to reuse the header.
File src/soc/intel/common/block/imc/imc.c:
https://review.coreboot.org/c/coreboot/+/83320/comment/a79dadc4_34d06506?usp... : PS2, Line 20: (1 << 29)
BIT(29)
Done