Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42828 )
Change subject: soc/amd/common: Use ACPIMMIO_GPIO0_BASE in ASL ......................................................................
soc/amd/common: Use ACPIMMIO_GPIO0_BASE in ASL
Change-Id: Ia18ee7dcfae3992eb4ecf52c3ebbd8e6daef756a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/amd/picasso/acpi/sb_fch.asl M src/soc/amd/stoneyridge/acpi/sb_fch.asl 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42828/1
diff --git a/src/soc/amd/picasso/acpi/sb_fch.asl b/src/soc/amd/picasso/acpi/sb_fch.asl index 00774fd..007df8d 100644 --- a/src/soc/amd/picasso/acpi/sb_fch.asl +++ b/src/soc/amd/picasso/acpi/sb_fch.asl @@ -34,7 +34,7 @@ ActiveLow, Exclusive, , , IRQR) { 0 } - Memory32Fixed (ReadWrite, 0xFED81500, 0x300) + Memory32Fixed (ReadWrite, ACPIMMIO_GPIO0_BASE, 0x300) } CreateDWordField (Local0, IRQR._INT, IRQN) If (PMOD) { @@ -44,7 +44,7 @@ } If (IRQN == 0x1f) { Return (ResourceTemplate() { - Memory32Fixed (ReadWrite, 0xFED81500, 0x300) + Memory32Fixed (ReadWrite, ACPIMMIO_GPIO0_BASE, 0x300) }) } Else { Return (Local0) diff --git a/src/soc/amd/stoneyridge/acpi/sb_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_fch.asl index 28e29c6..c999b67 100644 --- a/src/soc/amd/stoneyridge/acpi/sb_fch.asl +++ b/src/soc/amd/stoneyridge/acpi/sb_fch.asl @@ -30,7 +30,7 @@ { Interrupt (ResourceConsumer, Level, ActiveLow, Shared, , , ) { 7 } - Memory32Fixed (ReadWrite, 0xFED81500, 0x300) + Memory32Fixed (ReadWrite, ACPIMMIO_GPIO0_BASE, 0x300) })
Method (_STA, 0x0, NotSerialized)
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42828 )
Change subject: soc/amd/common: Use ACPIMMIO_GPIO0_BASE in ASL ......................................................................
Patch Set 3: Code-Review+2
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42828 )
Change subject: soc/amd/common: Use ACPIMMIO_GPIO0_BASE in ASL ......................................................................
Patch Set 4: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42828 )
Change subject: soc/amd/common: Use ACPIMMIO_GPIO0_BASE in ASL ......................................................................
Patch Set 8: Code-Review+2
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42828 )
Change subject: soc/amd/common: Use ACPIMMIO_GPIO0_BASE in ASL ......................................................................
Abandoned