Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43297 )
Change subject: mb/lenovo/t440p/romstage.c: Drop empty function ......................................................................
mb/lenovo/t440p/romstage.c: Drop empty function
There's a weak definition in chipset code that does nothing as well.
Change-Id: I2531e8b9d48eb4a1a667f22a81bb082ec98c1199 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/lenovo/t440p/romstage.c 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/43297/1
diff --git a/src/mainboard/lenovo/t440p/romstage.c b/src/mainboard/lenovo/t440p/romstage.c index ea1193f..859e690 100644 --- a/src/mainboard/lenovo/t440p/romstage.c +++ b/src/mainboard/lenovo/t440p/romstage.c @@ -26,10 +26,6 @@ RCBA_END_CONFIG, };
-void mainboard_config_superio(void) -{ -} - void mainboard_romstage_entry(void) { struct pei_data pei_data = {
Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43297 )
Change subject: mb/lenovo/t440p/romstage.c: Drop empty function ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43297 )
Change subject: mb/lenovo/t440p/romstage.c: Drop empty function ......................................................................
mb/lenovo/t440p/romstage.c: Drop empty function
There's a weak definition in chipset code that does nothing as well.
Change-Id: I2531e8b9d48eb4a1a667f22a81bb082ec98c1199 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43297 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tristan Corrick tristan@corrick.kiwi --- M src/mainboard/lenovo/t440p/romstage.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Tristan Corrick: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t440p/romstage.c b/src/mainboard/lenovo/t440p/romstage.c index 845bde8..a1bcac0 100644 --- a/src/mainboard/lenovo/t440p/romstage.c +++ b/src/mainboard/lenovo/t440p/romstage.c @@ -24,10 +24,6 @@ RCBA_END_CONFIG, };
-void mainboard_config_superio(void) -{ -} - void mainboard_romstage_entry(void) { struct pei_data pei_data = {