Attention is currently required from: Andrey Petrov, Himanshu Sahdev, Pratikkumar V Prajapati, Subrata Banik, Wonkyu Kim.
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75816?usp=email )
Change subject: drivers/intel/fsp2_0: Correct FSP performance timestamp unit ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/intel/fsp2_0/fsp_timestamp.c:
https://review.coreboot.org/c/coreboot/+/75816/comment/93e693ae_38b46bc9 : PS2, Line 56: TIMESTAMP_MS
isn't it getting converted here and L:47 to MS before printing?
https://review.coreboot.org/c/coreboot/+/62942
Check test prints in original patch it is in microseconds. I have observed same output. We are dividing by 1000 but data is still in microseconds. I confirmed with FSP team data is in nano second, so we need to divide by 10^6 to make it in ms. I thought better to change unit to us. I will change macro name as well.
+--------------------------------------------------+ |------ FSP Performance Timestamp Table Dump ------| +--------------------------------------------------+ | Perf-ID Timestamp(ms) String/GUID | +--------------------------------------------------+ 0 460253 SEC/52c05b14-0b98-496c-bc3b04b50211d680 50 460263 PEI/52c05b14-0b98-496c-bc3b04b50211d680 40 460274 PreMem/52c05b14-0b98-496c-bc3b04b50211d680