Attention is currently required from: Tarun Tuli, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68220 )
Change subject: mb/google/rex: Add initial fw config
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/rex/variants/rex0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68220/comment/7420e556_94574b6f
PS3, Line 156: probe DB_USB USB3
: probe DB_USB USB4
It will remove unnecessary ACPI code when USB DB is not present on a SKU. Is there any down side of it?
i assume those USB DBs are fixed and not configurable so that someone can build a board without those DBs attached.
hence, IMO, these are fixed configuration.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68220
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66f8b3e4ab414c03b8d63fdd31e0f3f424619340
Gerrit-Change-Number: 68220
Gerrit-PatchSet: 4
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Mon, 10 Oct 2022 08:17:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment