Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Angel Pons. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52895 )
Change subject: include/console: Fix duplicate entry of postcode 0x79 ......................................................................
Patch Set 1:
(1 comment)
File src/include/console/post_codes.h:
https://review.coreboot.org/c/coreboot/+/52895/comment/5aaa1cd9_e6af10a5 PS1, Line 191: /** : * \brief Pre call to RAM stage main() : * : * POSTed right before RAM stage main() is called from c_start.S : */ : #define POST_PRE_HARDWAREMAIN 0x7c : : /** : * \brief Entry into coreboot in RAM stage main() : * : * This is the first call in hardwaremain.c. If this code is POSTed, then : * ramstage has successfully loaded and started executing. : */ : #define POST_ENTRY_RAMSTAGE 0x80 Just a thought: Should POST_PRE_HARDWAREMAIN be 0x6e and POST_ENTRY_RAMSTAGE 0x6f so that the post codes appear in an increasing fashion? Does that even matter?