Attention is currently required from: Aryan Arora.
Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80185?usp=email )
Change subject: src/device/oprom/include/x86emu/regs.h: Fix checkpatch errors Add space after keywords, scope with a do-while loop for a multiline macro and split a single line if-else to multiline. ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80185/comment/9d4cf417_67611e1c : PS1, Line 6:
`A patch subject line should describe the change not the tool that found it`
Please fix.
https://review.coreboot.org/c/coreboot/+/80185/comment/0ee11043_5e43190b : PS1, Line 6:
`Possible long commit subject (prefer a maximum 65 characters)`
Please fix.
Patchset:
PS1: This seems OK to me.
I wonder if it is OK to use the ({ ... }) construct?