Attention is currently required from: Mario Scheithauer, Angel Pons, Arthur Heymans, Lean Sheng Tan.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69383 )
Change subject: soc/intel/ehl: Add MDIO operation to TSN GbE device
......................................................................
Patch Set 9:
(2 comments)
File src/soc/intel/elkhartlake/mdio.c:
https://review.coreboot.org/c/coreboot/+/69383/comment/81073a71_594bc2ea
PS7, Line 82: .read_resources = noop_read_resources,
: .set_resources = noop_set_resources,
static struct mdio_operations ehl_mdio_ops = { […]
Ack
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/69383/comment/d7bde0cb_6f62eed3
PS7, Line 93: .init = gbe_tsn_init,
: };
I am not sure what you mean exactly, but mdio_dev_enable(dev) assigns ops_mdio and it is called in g […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d1b9dd2f2ba8c18291fff314c13f0c3851784aa
Gerrit-Change-Number: 69383
Gerrit-PatchSet: 9
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 16 Nov 2022 12:21:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment