Change in coreboot[master]: mb/google/volteer/variant/lindar: Create dynamic fan table mechanism

[Kevin Chang (Code Review)]

Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Nick Vaccaro, Derek Huang, YH Lin, Zhuohao Lee.
Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52495 )

Change subject: mb/google/volteer/variant/lindar: Create dynamic fan table mechanism
......................................................................

Patch Set 4:

(2 comments)

File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/52495/comment/8b24e923_e5516eb3 
PS3, Line 462: 			chip drivers/intel/dptf
             : 				## Active Policy
             : 				register "policies.active" = "{
             : 					[0] = {.target = DPTF_CPU,
             : 						.thresholds = {TEMP_PCT(85, 90),
             : 							TEMP_PCT(80, 69),
             : 							TEMP_PCT(75, 56),
             : 							TEMP_PCT(70, 46),
             : 							TEMP_PCT(65, 36),}},
             : 					[1] = {.target = DPTF_TEMP_SENSOR_0,
             : 						.thresholds = {TEMP_PCT(50, 90),
             : 							TEMP_PCT(47, 69),
             : 							TEMP_PCT(45, 56),
             : 							TEMP_PCT(42, 46),
             : 							TEMP_PCT(39, 36),}},
             : 					[2] = {.target = DPTF_TEMP_SENSOR_1,
             : 						.thresholds = {TEMP_PCT(50, 90),
             : 							TEMP_PCT(47, 69),
             : 							TEMP_PCT(45, 56),
             : 							TEMP_PCT(42, 46),
             : 							TEMP_PCT(39, 36),}},
             : 					[3] = {.target = DPTF_TEMP_SENSOR_2,
             : 						.thresholds = {TEMP_PCT(50, 90),
             : 								TEMP_PCT(47, 69),
             : 								TEMP_PCT(45, 56),
             : 								TEMP_PCT(42, 46),
             : 								TEMP_PCT(39, 36),}},
             : 					[4] = {.target = DPTF_TEMP_SENSOR_3,
             : 						.thresholds = {TEMP_PCT(50, 90),
             : 								TEMP_PCT(47, 69),
             : 								TEMP_PCT(45, 56),
             : 								TEMP_PCT(42, 46),
             : 								TEMP_PCT(39, 36),}}}"
             : 
             : 				## Passive Policy
             : 				register "policies.passive" = "{
             : 					[0] = DPTF_PASSIVE(CPU, CPU,           95, 5000),
             : 					[1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000),
             : 					[2] = DPTF_PASSIVE(CHARGER,     TEMP_SENSOR_0, 65, 6000),
             : 					[3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 65, 6000),
             : 					[4] = DPTF_PASSIVE(CPU, TEMP_SENSOR_3, 65, 6000)}"
             : 
             : 				## Critical Policy
             : 				register "policies.critical" = "{
             : 					[0] = DPTF_CRITICAL(CPU,               105, SHUTDOWN),
             : 					[1] = DPTF_CRITICAL(TEMP_SENSOR_0,      75, SHUTDOWN),
             : 					[2] = DPTF_CRITICAL(TEMP_SENSOR_1,      75, SHUTDOWN),
             : 					[3] = DPTF_CRITICAL(TEMP_SENSOR_2,      75, SHUTDOWN),
             : 					[4] = DPTF_CRITICAL(TEMP_SENSOR_3,      75, SHUTDOWN)}"
             : 
             : 				## Power Limits Control
             : 				# 3-15W PL1 in 200mW increments, avg over 28-32s interval
             : 				# PL2 ranges from 15 to 60W, avg over 28-32s interval
             : 				register "controls.power_limits" = "{
             : 					.pl1 = {.min_power = 3000,
             : 						.max_power = 15000,
             : 						.time_window_min = 28 * MSECS_PER_SEC,
             : 						.time_window_max = 32 * MSECS_PER_SEC,
             : 						.granularity = 200,},
             : 					.pl2 = {.min_power = 60000,
             : 						.max_power = 60000,
             : 						.time_window_min = 28 * MSECS_PER_SEC,
             : 						.time_window_max = 32 * MSECS_PER_SEC,
             : 						.granularity = 1000,}}"
             : 
             : 				## Charger Performance Control (Control, mA)
             : 				register "controls.charger_perf" = "{
             : 					[0] = { 255, 1700 },
             : 					[1] = {  24, 1500 },
             : 					[2] = {  16, 1000 },
             : 					[3] = {   8,  500 }}"
             : 
             : 				## Fan Performance Control (Percent, Speed, Noise, Power)
             : 				register "controls.fan_perf" = "{
             : 					[0] = {  90, 6700, 220, 2200, },
             : 					[1] = {  80, 5800, 180, 1800, },
             : 					[2] = {  70, 5000, 145, 1450, },
             : 					[3] = {  60, 4900, 115, 1150, },
             : 					[4] = {  50, 3838,  90,  900, },
             : 					[5] = {  40, 2904,  55,  550, },
             : 					[6] = {  30, 2337,  30,  300, },
             : 					[7] = {  20, 1608,  15,  150, },
             : 					[8] = {  10,  800,  10,  100, },
             : 					[9] = {   0,    0,   0,   50, }}"
             : 
             : 				# Fan options
             : 				register "options.fan.fine_grained_control" = "1"
             : 				register "options.fan.step_size" = "2"
             : 
             : 				device generic 1 off end
             : 			end
> I don't think you meant to put this additional copy of everything in here ...

Updated in patchset 4, move those define to overridetree.cb.

File src/mainboard/google/volteer/variants/lindar/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/52495/comment/08517b9b_63921954 
PS3, Line 61: 		# Baseboard has these on, so they must be disabled here.
> this comment belongs down with line 104-106

Updated in patchset 4.