Attention is currently required from: Anastasios Koutian, Angel Pons.
Nico Huber has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83271?usp=email )
Change subject: cpu/intel/model_206ax: Allow turbo boost ratio limit configuration ......................................................................
Patch Set 5: Code-Review+1
(3 comments)
File src/cpu/intel/model_206ax/chip.h:
https://review.coreboot.org/c/coreboot/+/83271/comment/4e1a817f_e1408818?usp... : PS5, Line 63: int turbo_ratio_limit_4c; /* Turbo Ratio Limit for 4 cores acrive */ An array might look better?
File src/cpu/intel/model_206ax/model_206ax.h:
https://review.coreboot.org/c/coreboot/+/83271/comment/101ab793_7f0894e0?usp... : PS5, Line 49: The tabs are spurious at this point, please remove.
Alternatively, how about shortening the name? e.g. `PLATFORM_INFO_SET_TURBO_LIMITS` seems to fit.
File src/cpu/intel/model_206ax/model_206ax_init.c:
https://review.coreboot.org/c/coreboot/+/83271/comment/0bd80844_233a284d?usp... : PS5, Line 333: BIOS_NOTICE It's expected to be like this on most processors, isn't it? Then it should be `BIOS_INFO` at most.