Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47082 )
Change subject: mb/purism/librem_whl: Set SaGv to FixedHigh ......................................................................
mb/purism/librem_whl: Set SaGv to FixedHigh
Since the Librem Mini does not run on battery power, SaGv has little benefits and noticeably slows down testing, since memory training is run twice. Disabling SaGv cuts the 30-second cold boot time in half.
Change-Id: Ib02e42dcb4f20fdbdca85456c0dceafc59c782d8 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/purism/librem_whl/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/47082/1
diff --git a/src/mainboard/purism/librem_whl/devicetree.cb b/src/mainboard/purism/librem_whl/devicetree.cb index 2050332..8576b19 100644 --- a/src/mainboard/purism/librem_whl/devicetree.cb +++ b/src/mainboard/purism/librem_whl/devicetree.cb @@ -28,7 +28,7 @@ register "eist_enable" = "1"
# FSP Memory (soc/intel/cannonlake/romstage/fsp_params.c) - register "SaGv" = "SaGv_Enabled" + register "SaGv" = "SaGv_FixedHigh"
# FSP Silicon (soc/intel/cannonlake/fsp_params.c) # Serial I/O
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47082 )
Change subject: mb/purism/librem_whl: Set SaGv to FixedHigh ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Matt DeVillier,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47082
to look at the new patch set (#2).
Change subject: mb/purism/librem_whl: Set SaGv to FixedHigh ......................................................................
mb/purism/librem_whl: Set SaGv to FixedHigh
Since the Librem Mini does not run on battery power, SaGv has little benefits and noticeably slows down testing, since memory training is run twice. Disabling SaGv cuts the 30-second cold boot time in half.
Change-Id: Ib02e42dcb4f20fdbdca85456c0dceafc59c782d8 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/purism/librem_cnl/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/47082/2
Hello build bot (Jenkins), Matt DeVillier,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47082
to look at the new patch set (#3).
Change subject: mb/purism/librem_cnl: Set SaGv to FixedHigh ......................................................................
mb/purism/librem_cnl: Set SaGv to FixedHigh
Since the Librem Mini does not run on battery power, SaGv has little benefits and noticeably slows down testing, since memory training is run twice. Disabling SaGv cuts the 30-second cold boot time in half.
Change-Id: Ib02e42dcb4f20fdbdca85456c0dceafc59c782d8 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/purism/librem_cnl/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/47082/3
Hello build bot (Jenkins), Matt DeVillier,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47082
to look at the new patch set (#4).
Change subject: mb/purism/librem_cnl: Set SaGv to FixedHigh ......................................................................
mb/purism/librem_cnl: Set SaGv to FixedHigh
Since the Librem Mini does not run on battery power, SaGv has little benefits and noticeably slows down testing, since memory training is run twice. Disabling SaGv cuts the 30-second cold boot time in half.
Change-Id: Ib02e42dcb4f20fdbdca85456c0dceafc59c782d8 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/47082/4
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47082 )
Change subject: mb/purism/librem_cnl: Set SaGv to FixedHigh ......................................................................
Patch Set 4: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47082 )
Change subject: mb/purism/librem_cnl: Set SaGv to FixedHigh ......................................................................
mb/purism/librem_cnl: Set SaGv to FixedHigh
Since the Librem Mini does not run on battery power, SaGv has little benefits and noticeably slows down testing, since memory training is run twice. Disabling SaGv cuts the 30-second cold boot time in half.
Change-Id: Ib02e42dcb4f20fdbdca85456c0dceafc59c782d8 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47082 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb index 9fde5e9..918fa0e 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/variants/librem_mini/devicetree.cb @@ -15,7 +15,7 @@ register "eist_enable" = "1"
# FSP Memory (soc/intel/cannonlake/romstage/fsp_params.c) - register "SaGv" = "SaGv_Enabled" + register "SaGv" = "SaGv_FixedHigh"
# FSP Silicon (soc/intel/cannonlake/fsp_params.c)
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)