Attention is currently required from: Dinesh Sharma, Paul Menzel, Ravishankar Sarawadi.
Jérémy Compostella has posted comments on this change by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/82207?usp=email )
Change subject: drivers/wifi: Support Wi-Fi 7 11be Enablement ......................................................................
Patch Set 11:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82207/comment/64de1704_936e7586?usp... : PS8, Line 12: 320 MHz
Dose Wi-Fi 7 also support other frequencies?
I don't know why the 320 MHz frequency was referenced here. This feature is about overall Wi-Fi 7 (aka. 802.11be) enable/disable.
Commit Message:
https://review.coreboot.org/c/coreboot/+/82207/comment/f75ba460_7bde43e0?usp... : PS9, Line 12: Wi-Fi 7 320 MHz is disabled default in some countries like Japan.
- […]
Done
https://review.coreboot.org/c/coreboot/+/82207/comment/28391023_8e6453dd?usp... : PS9, Line 13: enable
enable/disable?
Done
https://review.coreboot.org/c/coreboot/+/82207/comment/11d59f3d_2cf93e88?usp... : PS9, Line 17: None
shouldn't this point to the rex fw branch ?
Done
https://review.coreboot.org/c/coreboot/+/82207/comment/699ea9c7_b3334666?usp... : PS9, Line 18: To test on Rex/Screebo
can you please add a meaningful TEST statement ? like how about DSD/DSM dump w/w. […]
Done
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/82207/comment/cd2d039e_f95044c6?usp... : PS8, Line 148: * 0 - 11BE disabled for China Mainland : * 1 - 11BE enabled for China Mainland : * : * Bit 1 : * 0 - 11BE disabled for South Korea : * 1 - 11BE enabled for South Korea
The commit message only says something about Japan.
Done
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/82207/comment/37daca57_26ac9cca?usp... : PS9, Line 147: 11BE
`802. […]
Done
https://review.coreboot.org/c/coreboot/+/82207/comment/53137ceb_a1ab4d75?usp... : PS9, Line 161: dsm_11be_enable
nit: `wifi_dsm_11be_country_enablement`
Done