Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56381 )
Change subject: soc/intel/common/block: Drop unused `intelblocks/mp_init.h` include
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56381/comment/18b49cbc_c04cabe4
PS1, Line 7: Make use of `cpu/intel/cpu_ids.h'
Drop unused `intelblocks/mp_init. […]
Ack
https://review.coreboot.org/c/coreboot/+/56381/comment/02bb27b7_9cde668d
PS1, Line 9: Remove inclusion of mp_init.h for getting CPUIDs and use dedicated
: cpu_ids.h file in SoC directory.
With the updated commit message, this should be removed.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56381
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8621a38214686b359ee0e7cdf7e92154af3cbc81
Gerrit-Change-Number: 56381
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 16 Jul 2021 09:45:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment