[M] Change in coreboot[master]: mb/google/nissa/var/craask: Modify GPIOs for NVMe

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71170 )

(

10 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
 )Change subject: mb/google/nissa/var/craask: Modify GPIOs for NVMe
......................................................................

mb/google/nissa/var/craask: Modify GPIOs for NVMe

Modify NVMe clkreq pin to GPP_D7 from GPP_D6.The design change is for
commonality of GPIO settings. To reserve craask GPIO table and add
craaskneto/craaskino's NVMe GPIO setting. In the change, clkreq# will
be 2 and clksrc is still 1.

BUG=b:259211172
TEST=Verify on reworked craask DUT to boot up from NVMe.

Change-Id: If45c1a87144d5370b1ca2525295fb7947639362f
Signed-off-by: Ren Kuo 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71170
Reviewed-by: Reka Norman 
Reviewed-by: Eric Lai 
Reviewed-by: Dtrain Hsu 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/brya/variants/craask/fw_config.c
M src/mainboard/google/brya/variants/craask/gpio.c
M src/mainboard/google/brya/variants/craask/overridetree.cb
3 files changed, 30 insertions(+), 39 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Ren Kuo: Looks good to me, but someone else must approve
  Dtrain Hsu: Looks good to me, approved
  Reka Norman: Looks good to me, approved
  Eric Lai: Looks good to me, approved

diff --git a/src/mainboard/google/brya/variants/craask/fw_config.c b/src/mainboard/google/brya/variants/craask/fw_config.c
index d667910..937e90d 100644
--- a/src/mainboard/google/brya/variants/craask/fw_config.c
+++ b/src/mainboard/google/brya/variants/craask/fw_config.c
@@ -50,39 +50,16 @@
 static const struct pad_config nvme_disable_pads[] = {
    /* B4  : SSD_PERST_L */
    PAD_NC_LOCK(GPP_B4, NONE, LOCK_CONFIG),
+	/* D7  : SSD_CLKREQ_ODL */
+	PAD_NC(GPP_D7, NONE),
    /* D11 : EN_PP3300_SSD */
    PAD_NC_LOCK(GPP_D11, NONE, LOCK_CONFIG),
    /* E17 : SSD_PLN_L */
    PAD_NC_LOCK(GPP_E17, NONE, LOCK_CONFIG),
-	/*
-	 * Note: don't disable GPP_D6 = SSD_CLKREQ_ODL, since this is used as
-	 * WWAN_EN on LTE variants.
-	 */
-};
-
-/*
- * GPP_D6 is used as WWAN_EN on LTE variants and SSD_CLKREQ_ODL on NVMe
- * variants (there is no craask variant supporting both LTE and NVMe).
- * In craask/gpio.c, it's set to WWAN_EN since this needs to be done in
- * bootblock. So we override it to SSD_CLKREQ_ODL here for NVMe variants.
- */
-static const struct pad_config nvme_enable_pads[] = {
-	/* D6  : SRCCLKREQ1# ==> SSD_CLKREQ_ODL */
-	PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1),
 };

void fw_config_gpio_padbased_override(struct pad_config *padbased_table)
 {
-	/*
-	 * Since GPP_D6 is used as WWAN_EN on LTE variants and SSD_CLKREQ_ODL on
-	 * NVMe variants, we don't support both together. If there's a variant
-	 * using both in the future, this GPIO handling will need to be updated.
-	 */
-	if (fw_config_probe(FW_CONFIG(DB_USB, DB_1C_LTE)) &&
-	    fw_config_probe(FW_CONFIG(STORAGE, STORAGE_NVME))) {
-		printk(BIOS_ERR, "LTE and NVMe together is not supported on craask\n");
-	}
-
    if (!fw_config_probe(FW_CONFIG(DB_USB, DB_1C_LTE))) {
    	printk(BIOS_INFO, "Disable LTE-related GPIO pins on craask.\n");
    	gpio_padbased_override(padbased_table, lte_disable_pads,
@@ -107,16 +84,7 @@
    					ARRAY_SIZE(stylus_disable_pads));
    }

-	if (!fw_config_is_provisioned() ||
-	    fw_config_probe(FW_CONFIG(STORAGE, STORAGE_NVME))) {
-		/*
-		 * Note: this must be done after lte_disable_pads, otherwise
-		 * GPP_D6 will be disabled again.
-		 */
-		printk(BIOS_INFO, "Enable NVMe SSD GPIO pins.\n");
-		gpio_padbased_override(padbased_table, nvme_enable_pads,
-						ARRAY_SIZE(nvme_enable_pads));
-	} else {
+	if (fw_config_is_provisioned() && !fw_config_probe(FW_CONFIG(STORAGE, STORAGE_NVME))) {
    	printk(BIOS_INFO, "Disable NVMe SSD GPIO pins.\n");
    	gpio_padbased_override(padbased_table, nvme_disable_pads,
    					ARRAY_SIZE(nvme_disable_pads));
diff --git a/src/mainboard/google/brya/variants/craask/gpio.c b/src/mainboard/google/brya/variants/craask/gpio.c
index 5d0db35..bebc8d2 100644
--- a/src/mainboard/google/brya/variants/craask/gpio.c
+++ b/src/mainboard/google/brya/variants/craask/gpio.c
@@ -13,8 +13,8 @@
    PAD_CFG_GPO_LOCK(GPP_B4, 1, LOCK_CONFIG),
    /* D6  : WWAN_EN */
    PAD_CFG_GPO(GPP_D6, 1, DEEP),
-	/* D7  : WLAN_CLKREQ_ODL */
-	PAD_NC(GPP_D7, NONE),
+	/* D7  : SRCCLKREQ1# ==> SSD_CLKREQ_ODL */
+	PAD_CFG_NF(GPP_D7, NONE, DEEP, NF1),
    /* D11 : EN_PP3300_SSD */
    PAD_CFG_GPO_LOCK(GPP_D11, 1, LOCK_CONFIG),
    /* E17 : SSD_PLN_L */
diff --git a/src/mainboard/google/brya/variants/craask/overridetree.cb b/src/mainboard/google/brya/variants/craask/overridetree.cb
index 1a733fb..19cf876 100644
--- a/src/mainboard/google/brya/variants/craask/overridetree.cb
+++ b/src/mainboard/google/brya/variants/craask/overridetree.cb
@@ -447,10 +447,10 @@
    		probe SD_CARD SD_GL9750S
    	end
    	device ref pcie_rp9 on
-			# Enable NVMe SSD PCIe 9-12 using clk 1
+			# Enable NVMe SSD PCIe 9-12 using clk 2
    		register "pch_pcie_rp[PCH_RP(9)]" = "{
    			.clk_src = 1,
-				.clk_req = 1,
+				.clk_req = 2,
    			.flags = PCIE_RP_LTR | PCIE_RP_AER,
    		}"
    	end