Change in coreboot[master]: mb/purism/librem_skl: guard selection of GMA presence straps

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Matt DeVillier (Code Review)

15 Jul 2020 15 Jul '20

11:27 p.m.

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43489 )

Change subject: mb/purism/librem_skl: guard selection of GMA presence straps ......................................................................

mb/purism/librem_skl: guard selection of GMA presence straps

unconditionally selecting GFX_GMA_IGNORE_PRESENCE_STRAPS creates a hard dependency on MAINBOARD_USE_LIBGFXINIT, preventing a user from using an alternative (or no) display init, so guard it appropriately.

Test: build Librem 13v4 with FSP, VGA, and no display init.

Change-Id: Ibdfe0b2bf26a9a49fb5cb669329690894de71dbd Signed-off-by: Matt DeVillier matt.devillier@puri.sm --- M src/mainboard/purism/librem_skl/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/43489/1

diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index cd8fc66..f47c368 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -2,7 +2,7 @@ def_bool n select BOARD_ROMSIZE_KB_16384 select DRIVERS_GENERIC_CBFS_SERIAL - select GFX_GMA_IGNORE_PRESENCE_STRAPS + select GFX_GMA_IGNORE_PRESENCE_STRAPS if MAINBOARD_USE_LIBGFXINIT select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select INTEL_GMA_HAVE_VBT

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Angel Pons (Code Review)

16 Jul 16 Jul

12:51 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43489 )

Change subject: mb/purism/librem_skl: guard selection of GMA presence straps ......................................................................

Patch Set 1: Code-Review-1

How about making GFX_GMA_IGNORE_PRESENCE_STRAPS not depend on libgfxinit?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdfe0b2bf26a9a49fb5cb669329690894de71dbd Gerrit-Change-Number: 43489 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 15 Jul 2020 22:51:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

1:05 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43489 )

Change subject: mb/purism/librem_skl: guard selection of GMA presence straps ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43489/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_skl/Kconfig:

https://review.coreboot.org/c/coreboot/+/43489/1/src/mainboard/purism/librem... PS1, Line 5: select GFX_GMA_IGNORE_PRESENCE_STRAPS if MAINBOARD_USE_LIBGFXINIT This will need to be done for each mainboard that wants to use this option. How about this? CB:43491

-- To view, visit https://review.coreboot.org/c/coreboot/+/43489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdfe0b2bf26a9a49fb5cb669329690894de71dbd Gerrit-Change-Number: 43489 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 15 Jul 2020 23:05:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Matt DeVillier (Code Review)

3:11 a.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43489 )

Change subject: mb/purism/librem_skl: guard selection of GMA presence straps ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43489/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_skl/Kconfig:

https://review.coreboot.org/c/coreboot/+/43489/1/src/mainboard/purism/librem... PS1, Line 5: select GFX_GMA_IGNORE_PRESENCE_STRAPS if MAINBOARD_USE_LIBGFXINIT

...

This will need to be done for each mainboard that wants to use this option. […]

does it make sense to have that option selectable and not do anything? I'm not opposed to your solution, just wondering if we'd ever use it otherwise

-- To view, visit https://review.coreboot.org/c/coreboot/+/43489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdfe0b2bf26a9a49fb5cb669329690894de71dbd Gerrit-Change-Number: 43489 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 16 Jul 2020 01:11:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Nico Huber (Code Review)

11:08 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43489 )

Change subject: mb/purism/librem_skl: guard selection of GMA presence straps ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43489/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_skl/Kconfig:

https://review.coreboot.org/c/coreboot/+/43489/1/src/mainboard/purism/librem... PS1, Line 5: select GFX_GMA_IGNORE_PRESENCE_STRAPS if MAINBOARD_USE_LIBGFXINIT

...

does it make sense to have that option selectable and not do anything? I'm not opposed to your solut […]

We won't use it. But the other boolean options are already outside the if for the same reason. CB:43491 should go in anyway, IMHO.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdfe0b2bf26a9a49fb5cb669329690894de71dbd Gerrit-Change-Number: 43489 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 16 Jul 2020 09:08:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier matt.devillier@gmail.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Matt DeVillier (Code Review)

6:27 p.m.

Matt DeVillier has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43489 )

Change subject: mb/purism/librem_skl: guard selection of GMA presence straps ......................................................................

Abandoned

abandoned in favor of CB:43491

-- To view, visit https://review.coreboot.org/c/coreboot/+/43489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdfe0b2bf26a9a49fb5cb669329690894de71dbd Gerrit-Change-Number: 43489 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

Paul Menzel (Code Review)

27 Jul 27 Jul

4:30 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43489 )

Change subject: mb/purism/librem_skl: guard selection of GMA presence straps ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43489/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43489/1//COMMIT_MSG@9 PS1, Line 9: unconditionally Please start with a capital letter.

...

Unconditionally

-- To view, visit https://review.coreboot.org/c/coreboot/+/43489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdfe0b2bf26a9a49fb5cb669329690894de71dbd Gerrit-Change-Number: 43489 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 27 Jul 2020 14:30:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1563

days inactive

1575

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Matt DeVillier (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)