Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22215 )
Change subject: [WIP]nb/intel/sandybridge/raminit: Add ECC support
......................................................................
Patch Set 16:
(3 comments)
https://review.coreboot.org/c/coreboot/+/22215/9/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/c/coreboot/+/22215/9/src/northbridge/intel/sandy...
PS9, Line 173: size_t
Why size_t?
Ack
https://review.coreboot.org/c/coreboot/+/22215/9/src/northbridge/intel/sandy...
PS9, Line 269: non ECC
this functions as an adjective: non-ECC
Done
https://review.coreboot.org/c/coreboot/+/22215/9/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/22215/9/src/northbridge/intel/sandy...
PS9, Line 465: if (ctrl->ecc_enabled)
Could use a ternary operator, or would it look too bad? […]
Bleh
--
To view, visit
https://review.coreboot.org/c/coreboot/+/22215
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1206746332c9939a78b67e7b48d3098bdef8a2ed
Gerrit-Change-Number: 22215
Gerrit-PatchSet: 16
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christoph Pomaska
github@slrie.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jonathan Kollasch
jakllsch@kollasch.net
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 Apr 2020 22:30:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment