Attention is currently required from: Felix Singer, Jason Glenesk, Martin L Roth.
Angel Pons has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/84046?usp=email )
Change subject: Docs/releases: Update 24.08 release notes ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
File Documentation/releases/coreboot-24.08-relnotes.md:
https://review.coreboot.org/c/coreboot/+/84046/comment/b4d1d7cc_8ae5e067?usp... : PS1, Line 23: ## Introduce region_create() functions : : We introduce two new functions to create region objects. They allow us to check : for integer overflows (region_create_untrusted()) or assert their absence : (region_create()). : : This fixes potential overflows in region_overlap() checks in SMI handlers, where : we would wrongfully report MMIO as *not* overlapping SMRAM. : : Also, two cases of strtol() in parse_region() (cbfstool), where the results were : implicitly converted to `size_t`, are replaced with the unsigned strtoul(). nit: use inline code blocks for function names? `like this`
https://review.coreboot.org/c/coreboot/+/84046/comment/c46f8ddf_2331510a?usp... : PS1, Line 39: https://review.coreboot.org/79905 If possible, would be nice to replace these links with commit hashes once submitted
https://review.coreboot.org/c/coreboot/+/84046/comment/9c2d8b41_7c50b9cb?usp... : PS1, Line 65: which were mostly fixed Grammar: which (the issue) *was* mostly fixed
```suggestion and had this issue, which was mostly fixed by using exception handlers in the ```
If the intent is to say that "the mainboards were mostly fixed", I would word this differently but it still sounds odd to me:
and had this issue, **but they** were mostly fixed by ...
https://review.coreboot.org/c/coreboot/+/84046/comment/c70b29ef_6d1bc9f8?usp... : PS1, Line 287: * src/soc/intel/pantherlake I think a verb is missing?
```suggestion * Added src/soc/intel/pantherlake ```