Attention is currently required from: Lance Zhao, Martin Roth.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49317 )
Change subject: drivers/uart: Add ACPI SPCR table generation
......................................................................
Patch Set 4:
(2 comments)
File src/include/acpi/acpi_device.h:
https://review.coreboot.org/c/coreboot/+/49317/comment/5540f4a2_c77d10e3
PS4, Line 476: flow_control
I don't see this one in the spec
https://review.coreboot.org/c/coreboot/+/49317/comment/e4b89fe2_b8ab91b8
PS4, Line 503: (1 << 0)
nit: BIT macro?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1e7c17adcf5b2a8206a8308e057855819ec413a
Gerrit-Change-Number: 49317
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Tue, 12 Jan 2021 16:39:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment