Attention is currently required from: Lance Zhao, Wonkyu Kim, Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55310 )
Change subject: ACPI: Add acpi_create_madt_ioapic_from_hw()
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
But the general purpose of the code is correct, IOAPIC ID will adjust dynamically depends on the loc […]
The `from_hw` suffix is because the function calls `get_ioapic_id()` to obtain the IOAPIC ID, and this ID is read from the hardware registers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55310
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia173582eaad305000f958c5d207e9efaa06d8750
Gerrit-Change-Number: 55310
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 20 Jun 2021 10:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Gerrit-MessageType: comment