Attention is currently required from: Maciej Pijanowski, Michał Żygowski, Jakub Czapiga, Stefan Reinauer, Michal Zygowski.
Karol Zmyslowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73934 )
Change subject: util/inteltool: Add support for Jasper Lake ......................................................................
Patch Set 9:
(11 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/73934/comment/ad89fe62_55d54a03 PS4, Line 11: Document Number: 618876
@Karol, please change it to refer to Datasheet Vol 2, as it seems to contain the necessary informati […]
Corrected, in current commit (Patchset #9)
Patchset:
PS9: Respond to comments.
File util/inteltool/gpio_names/jasperlake.h:
https://review.coreboot.org/c/coreboot/+/73934/comment/df7a0916_7942c956 PS4, Line 141: "L_BLKTEN", : "L_BLKTCTL", : "LVDDEN", : "SYS_PWROK", : "SYS_RESETB", : "MLK_RSTB",
What NF1 stands for?
Corrected, in Patchset #8
https://review.coreboot.org/c/coreboot/+/73934/comment/03fdf5f1_0955318f PS4, Line 191: "JTAG_TD0", : "JTAGX", : "PRDYB", : "PREQB", : "CPU_TRSTB", : "JTAG_TDI", : "JTAG_TMS", : "JTAG_TCK", : "ITP_PMODE"
Same here, copy as NF1 and increase func_count
Corrected, in patchset #8
https://review.coreboot.org/c/coreboot/+/73934/comment/c2451d42_0dd4fb24 PS4, Line 281: "GSPI2_CLK_LOOPBK", : "SPI1_CLK_LOOPBK",
Other microarchitectures incoporate the clock loopbacks to the previous GPIO group. […]
Corrected, in patchset #9.
https://review.coreboot.org/c/coreboot/+/73934/comment/9c95e8a7_8987da95 PS4, Line 312: "GSPI0_CLK_LOOPBK", : "GSPI1_CLK_LOOPBK",
Other microarchitectures incoporate the clock loopbacks to the previous GPIO group. […]
Corrected, in patchset #9.
https://review.coreboot.org/c/coreboot/+/73934/comment/f4965dfa_3ccd5c1c PS4, Line 336: .pad_count = ARRAY_SIZE(jasperlake_pch_group_r_names) / 6, : .func_count = 6,
There are only 3 columns not 6
Corrected.
https://review.coreboot.org/c/coreboot/+/73934/comment/48da3a33_26ce305e PS4, Line 354: .pad_count = ARRAY_SIZE(jasperlake_pch_group_s_names) / 2, : .func_count = 2,
Ack
Corrected.
https://review.coreboot.org/c/coreboot/+/73934/comment/516f63e8_0b926966 PS4, Line 361: "HDACPU_SDI", : "HDACPU_SDO", : "HDACPU_SCLK", : "PM_SYNC", : "PECI", : "CPUPWRGD", : "THRMTRIPB", : "PLTRST_CPUB", : "PM_DOWN", : "TRIGGER_IN", : "TRIGGER_OUT", : "UFS_RESETB", : "CLKOUT_CPURTC", : "VCCST_PWRGD", : "C10_WAKE",
Ack
Corrected.
https://review.coreboot.org/c/coreboot/+/73934/comment/89b23c29_f205cd87 PS4, Line 386: "VGPIO_PCIE0", : "VGPIO_PCIE1", : "VGPIO_PCIE2", : "VGPIO_PCIE3", : "VGPIO_PCIE4", : "VGPIO_PCIE5", : "VGPIO_PCIE6", : "VGPIO_PCIE7", : "VGPIO_PCIE8", : "VGPIO_PCIE9", : "VGPIO_PCIE10", : "VGPIO_PCIE11", : "VGPIO_PCIE12", : "VGPIO_PCIE13", : "VGPIO_PCIE14", : "VGPIO_PCIE15", : "VGPIO_PCIE16", : "VGPIO_PCIE17", : "VGPIO_PCIE18", : "VGPIO_PCIE19", : "VGPIO_PCIE20", : "VGPIO_PCIE21", : "VGPIO_PCIE22", : "VGPIO_PCIE23", : "VGPIO_PCIE24", : "VGPIO_PCIE25", : "VGPIO_PCIE26", : "VGPIO_PCIE27", : "VGPIO_PCIE28", : "VGPIO_PCIE29", : "VGPIO_PCIE30", : "VGPIO_PCIE31", : "VGPIO_PCIE32", : "VGPIO_PCIE33", : "VGPIO_PCIE34", : "VGPIO_PCIE35", : "VGPIO_PCIE36", : "VGPIO_PCIE37", : "VGPIO_PCIE38", : "VGPIO_PCIE39", : "VGPIO_PCIE40", : "VGPIO_PCIE41", : "VGPIO_PCIE42", : "VGPIO_PCIE43", : "VGPIO_PCIE44", : "VGPIO_PCIE45", : "VGPIO_PCIE46", : "VGPIO_PCIE47", : "VGPIO_PCIE48", : "VGPIO_PCIE49", : "VGPIO_PCIE50", : "VGPIO_PCIE51", : "VGPIO_PCIE52", : "VGPIO_PCIE53", : "VGPIO_PCIE54", : "VGPIO_PCIE55", : "VGPIO_PCIE56", : "VGPIO_PCIE57", : "VGPIO_PCIE58", : "VGPIO_PCIE59", : "VGPIO_PCIE60", : "VGPIO_PCIE61", : "VGPIO_PCIE62", : "VGPIO_PCIE63", : "VGPIO_PCIE64", : "VGPIO_PCIE65", : "VGPIO_PCIE66", : "VGPIO_PCIE67", : "VGPIO_PCIE68", : "VGPIO_PCIE69", : "VGPIO_PCIE70", : "VGPIO_PCIE71", : "VGPIO_PCIE72", : "VGPIO_PCIE73", : "VGPIO_PCIE74", : "VGPIO_PCIE75", : "VGPIO_PCIE76", : "VGPIO_PCIE77", : "VGPIO_PCIE78", : "VGPIO_PCIE79",
Ack
Corrected.
https://review.coreboot.org/c/coreboot/+/73934/comment/7c4869e5_55fe63a9 PS4, Line 475: "VGPIO_USB0", : "VGPIO_USB1", : "VGPIO_USB2", : "VGPIO_USB3", : "VGPIO_USB4", : "VGPIO_USB5", : "VGPIO_USB6", : "VGPIO_USB7", : "VGPIO_USB8", : "VGPIO_USB9", : "VGPIO_USB10", : "VGPIO_USB11",
Ack
Corrected.
-
Karol Zmyslowski (Code Review)