Attention is currently required from: Furquan Shaikh, Jakub Czapiga. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57271 )
Change subject: cbfs: Make sure all cases of single file header corruption are isolated ......................................................................
Patch Set 1:
(1 comment)
File src/commonlib/bsd/cbfs_private.c:
https://review.coreboot.org/c/coreboot/+/57271/comment/2e23b75c_5f09f2f7 PS1, Line 54: data_length > devsize
The second condition will be true only if file data is larger than whole rdev. […]
The second condition is an overflow check. Without that, a data_length of 0xffffffff (like you might see if a data block got accidentally erased just after the beginning of the file header) would not be caught by this check.