Change in coreboot[master]: Update chromeec submodule to upstream master

List overview All Threads
Download

newer

older

Change in coreboot[master]: Update...

Change in coreboot[master]:...

Patrick Georgi (Code Review)

26 Sep 2019 26 Sep '19

4:13 p.m.

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35624 )

Change subject: Update chromeec submodule to upstream master ......................................................................

Update chromeec submodule to upstream master

Updating from commit id 860fe2962: 2018-12-29 05:45:29 -0800 - (mt_scp/ipi: Support host command.)

to commit id 1906434c4: 2019-09-26 10:32:54 +0000 - (tcpci: add missing CPRINTS argument)

This brings in 1681 new commits.

Change-Id: Ieb4f00b21a4354bb634c3427c73260123b54ac2a Signed-off-by: Patrick Georgi pgeorgi@google.com --- M 3rdparty/chromeec 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/35624/1

diff --git a/3rdparty/chromeec b/3rdparty/chromeec index 860fe29..1906434 160000 --- a/3rdparty/chromeec +++ b/3rdparty/chromeec @@ -1 +1 @@ -Subproject commit 860fe2962d40ee901369d1dc67f4aa7a7a42ba4d +Subproject commit 1906434c4e62fac6792b6b81874810495be49b2e

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Paul Menzel (Code Review)

26 Sep 26 Sep

5:49 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35624 )

Change subject: Update chromeec submodule to upstream master ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/35624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb4f00b21a4354bb634c3427c73260123b54ac2a Gerrit-Change-Number: 35624 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 26 Sep 2019 17:49:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jacob Garber (Code Review)

7 p.m.

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35624 )

Change subject: Update chromeec submodule to upstream master ......................................................................

Patch Set 1:

I'm working on some fixes for GCC 9 in chromeec, so I'd like to land those first before we bump this. Eg. https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1826289

-- To view, visit https://review.coreboot.org/c/coreboot/+/35624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb4f00b21a4354bb634c3427c73260123b54ac2a Gerrit-Change-Number: 35624 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-Comment-Date: Thu, 26 Sep 2019 19:00:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jacob Garber (Code Review)

27 Sep 27 Sep

5:20 a.m.

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35624 )

Change subject: Update chromeec submodule to upstream master ......................................................................

Patch Set 1:

...

Patch Set 1:

...
Patch Set 1:

I'm working on some fixes for GCC 9 in chromeec, so I'd like to land those first before we bump this. Eg. https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1826289

There will be more regular updates to the various submodules in the near future, so I wouldn't worry about this landing already. Or does this break something compared to the current state?

The coreboot patch to use GCC 9 is currently blocked on some build errors in chrome EC. I was working on a fix for that that got merged earlier today, and just wanted it to be included in this :)

-- To view, visit https://review.coreboot.org/c/coreboot/+/35624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb4f00b21a4354bb634c3427c73260123b54ac2a Gerrit-Change-Number: 35624 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-Comment-Date: Fri, 27 Sep 2019 05:20:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2 Oct 2 Oct

12:19 p.m.

Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35624

to look at the new patch set (#2).

Change subject: Update chromeec submodule to upstream master ......................................................................

Update chromeec submodule to upstream master

Updating from commit id 860fe2962: 2018-12-29 05:45:29 -0800 - (mt_scp/ipi: Support host command.)

to commit id a1afae4e0: 2019-10-02 11:47:45 +0000 - (juniper: initial setup)

This brings in 1723 new commits.

Change-Id: Ieb4f00b21a4354bb634c3427c73260123b54ac2a Signed-off-by: Patrick Georgi pgeorgi@google.com --- M 3rdparty/chromeec 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/35624/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb4f00b21a4354bb634c3427c73260123b54ac2a Gerrit-Change-Number: 35624 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Jacob Garber jgarber1@ualberta.ca Gerrit-MessageType: newpatchset

Jacob Garber (Code Review)

5:46 p.m.

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35624 )

Change subject: Update chromeec submodule to upstream master ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/35624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb4f00b21a4354bb634c3427c73260123b54ac2a Gerrit-Change-Number: 35624 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 02 Oct 2019 17:46:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

3 Oct 3 Oct

1:53 a.m.

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35624 )

Change subject: Update chromeec submodule to upstream master ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb4f00b21a4354bb634c3427c73260123b54ac2a Gerrit-Change-Number: 35624 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 03 Oct 2019 01:53:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:43 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35624 )

Change subject: Update chromeec submodule to upstream master ......................................................................

Update chromeec submodule to upstream master

Updating from commit id 860fe2962: 2018-12-29 05:45:29 -0800 - (mt_scp/ipi: Support host command.)

to commit id a1afae4e0: 2019-10-02 11:47:45 +0000 - (juniper: initial setup)

This brings in 1723 new commits.

Change-Id: Ieb4f00b21a4354bb634c3427c73260123b54ac2a Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35624 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jacob Garber jgarber1@ualberta.ca Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M 3rdparty/chromeec 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Jacob Garber: Looks good to me, but someone else must approve

diff --git a/3rdparty/chromeec b/3rdparty/chromeec index 860fe29..a1afae4 160000 --- a/3rdparty/chromeec +++ b/3rdparty/chromeec @@ -1 +1 @@ -Subproject commit 860fe2962d40ee901369d1dc67f4aa7a7a42ba4d +Subproject commit a1afae4e002a3eccd7835ac898259b0690e9e61a

-- To view, visit https://review.coreboot.org/c/coreboot/+/35624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb4f00b21a4354bb634c3427c73260123b54ac2a Gerrit-Change-Number: 35624 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

HAOUAS Elyes (Code Review)

5:41 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35624 )

Change subject: Update chromeec submodule to upstream master ......................................................................

Patch Set 3:

got this : $git reset --hard origin / master &&git pull && git submodule update --init --checkout HEAD is now at 22f009901d Update chromeec submodule to upstream master Already up to date. remote: Counting objects: 3907, done remote: Finding sources: 100% (21784/21784) remote: Total 21784 (delta 17584), reused 21784 (delta 17584) Receiving objects: 100% (21784/21784), 7.47 MB | 7.25 Mio/s, done. error: unknown object type 0 at offset 39580547 in /home/elyes/stage/coreboot/.git/modules/3rdparty/chromeec/objects/pack/pack-74c8d566ce0ff6d756cec595a45e1fedf962719b.pack fatal: the object bundled 6949464dbb30564c64ca8c728450c09109ba25cb (stored in /home/elyes/stage/coreboot/.git/modules/3rdparty/chromeec/objects/pack/pack-74c8d566ce0ff6d756cec595a45e1fedf962719b.pack) is corrupted fatal: index-pack failure Unable to retrieve to sub-module path '3rdparty / chromeec'; direct repatriation testing of a1afae4e002a3eccd7835ac898259b0690e9e61a: error: The server does not allow a request for the unpublished a1afae4e002a3eccd7835ac898259b0690e9e61a object '3rdparty/chromeec' sub-module path recovered, but it did not contain a1afae4e002a3eccd7835ac898259b0690e9e61a. Direct recovery of this commit failed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb4f00b21a4354bb634c3427c73260123b54ac2a Gerrit-Change-Number: 35624 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Thu, 03 Oct 2019 05:41:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:43 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35624 )

Change subject: Update chromeec submodule to upstream master ......................................................................

Patch Set 3:

...

Patch Set 3:

got this : $git reset --hard origin / master &&git pull && git submodule update --init --checkout HEAD is now at 22f009901d Update chromeec submodule to upstream master Already up to date. remote: Counting objects: 3907, done remote: Finding sources: 100% (21784/21784) remote: Total 21784 (delta 17584), reused 21784 (delta 17584) Receiving objects: 100% (21784/21784), 7.47 MB | 7.25 Mio/s, done. error: unknown object type 0 at offset 39580547 in /home/elyes/stage/coreboot/.git/modules/3rdparty/chromeec/objects/pack/pack-74c8d566ce0ff6d756cec595a45e1fedf962719b.pack fatal: the object bundled 6949464dbb30564c64ca8c728450c09109ba25cb (stored in /home/elyes/stage/coreboot/.git/modules/3rdparty/chromeec/objects/pack/pack-74c8d566ce0ff6d756cec595a45e1fedf962719b.pack) is corrupted fatal: index-pack failure Unable to retrieve to sub-module path '3rdparty / chromeec'; direct repatriation testing of a1afae4e002a3eccd7835ac898259b0690e9e61a: error: The server does not allow a request for the unpublished a1afae4e002a3eccd7835ac898259b0690e9e61a object '3rdparty/chromeec' sub-module path recovered, but it did not contain a1afae4e002a3eccd7835ac898259b0690e9e61a. Direct recovery of this commit failed.

That looks like your local chromeec clone is broken in some way (object ... stored in ... pack074c8 ... is corrupted)

-- To view, visit https://review.coreboot.org/c/coreboot/+/35624 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieb4f00b21a4354bb634c3427c73260123b54ac2a Gerrit-Change-Number: 35624 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Thu, 03 Oct 2019 16:43:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1673

days inactive

1680

days old

coreboot-gerrit@coreboot.org

9 comments

5 participants

tags (0)

participants (5)

HAOUAS Elyes (Code Review)
Jacob Garber (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Stefan Reinauer (Code Review)