Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83989?usp=email )
Change subject: soc/mediatek: Move SNFC pad_func into MediaTek common directory ......................................................................
Patch Set 4:
(5 comments)
File src/soc/mediatek/common/include/soc/snfc.h:
PS1:
move to flash_controller_common. […]
Done
File src/soc/mediatek/common/snfc.c:
https://review.coreboot.org/c/coreboot/+/83989/comment/bb34f639_c52bfcb6?usp... : PS1, Line 9: uint8_t drive_strength
enum gpio_drv strength
Done
https://review.coreboot.org/c/coreboot/+/83989/comment/a6dab8a8_2a37a63c?usp... : PS1, Line 17: 14
The `(drive_strength + 1) * 2` calculation should be in a function (such as `gpio_drv_ma`) in gpio_c […]
Done
https://review.coreboot.org/c/coreboot/+/83989/comment/902cb2c9_7cdb65dc?usp... : PS1, Line 8: : void mtk_snfc_init_pad_func(const struct pad_func *pad_func, uint8_t drive_strength) : { : : gpio_set_pull(pad_func->gpio, GPIO_PULL_ENABLE, pad_func->select); : gpio_set_mode(pad_func->gpio, pad_func->func); : : if (gpio_set_driving(pad_func->gpio, drive_strength) < 0) : printk(BIOS_ERR, : "%s: failed to set pin drive to 14 mA for %d\n", : __func__, pad_func->gpio.id); : else : printk(BIOS_DEBUG, "%s: got pin drive: %#x\n", __func__, : gpio_get_driving(pad_func->gpio)); : }
what about moving this function to flash_controller. […]
Done
https://review.coreboot.org/c/coreboot/+/83989/comment/6da83d4f_59398b6c?usp... : PS1, Line 23:
remove blank lines
Done