Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35680 )
Change subject: cpu/qemu-x86: Add x86_64 bootblock support ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35680/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35680/2//COMMIT_MSG@15 PS2, Line 15: Introduce a new tool called pgtblgen that creates x86 long mode compatible : page tables and writes those to a file.
That's written in go and requires CSV as input. […]
Ack
https://review.coreboot.org/c/coreboot/+/35680/2/src/cpu/qemu-x86/cache_as_r... File src/cpu/qemu-x86/cache_as_ram_bootblock.S:
https://review.coreboot.org/c/coreboot/+/35680/2/src/cpu/qemu-x86/cache_as_r... PS2, Line 42: #include <cpu/x86/64bit/entry64.inc>
Could be place in a common file, but everything after this include runs in long mode already. […]
Ack
https://review.coreboot.org/c/coreboot/+/35680/2/src/cpu/x86/64bit/entry64.i... File src/cpu/x86/64bit/entry64.inc:
https://review.coreboot.org/c/coreboot/+/35680/2/src/cpu/x86/64bit/entry64.i... PS2, Line 25: $(CONFIG_ARCH_X86_64_PGTBL_LOC)
no that doesn't work. […]
Looking at arch/x86/memlayout.ld it looks like that is not the case for the bootblock, but it might indeed not be the best idea.
walkcbfs could also work, but I guess the pd somehow needs to know where it's going to be?
-
Arthur Heymans (Code Review)