Change in ...coreboot[master]: sb/intel/lynxpoint: Allow the flash chip to be write-protected

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29977 ) Change subject: sb/intel/lynxpoint: Allow the flash chip to be write-protected ...................................................................... Patch Set 1: While technically correct I don't see why we need to duplicate code and Kconfig options. Can you move the bd82x6x code to sb/intel/common and just use that instead ? -- To view, visit https://review.coreboot.org/c/coreboot/+/29977 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I781082b1ed507b00815d1e85aec3e56ae5a4bef2 Gerrit-Change-Number: 29977 Gerrit-PatchSet: 1 Gerrit-Owner: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Tristan Corrick <tristan@corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Fri, 30 Nov 2018 14:05:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
participants (1)
-
Patrick Rudolph (Code Review)