Attention is currently required from: Tim Crawford, Nico Huber, Jeremy Soller, Tim Wawrzynczak, Paul Menzel, Angel Pons.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57034 )
Change subject: drivers/gfx/nvidia: Add driver for NVIDIA Optimus
......................................................................
Patch Set 2:
(3 comments)
File src/drivers/gfx/nvidia/acpi/gpu.asl:
https://review.coreboot.org/c/coreboot/+/57034/comment/c86bbf62_dc9cd124
PS2, Line 95: Debug = " DGPU_PWR_EN high"
I would use Printf for debug output; but that's just personal preference
https://review.coreboot.org/c/coreboot/+/57034/comment/44ce1c40_87ba4c42
PS2, Line 160: Zero
0
https://review.coreboot.org/c/coreboot/+/57034/comment/0a687461_b13fac02
PS2, Line 184: Zero
0
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57034
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2dec7aa2c8db7994f78a7cc1220502676e248465
Gerrit-Change-Number: 57034
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 19 Aug 2021 11:13:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment