Attention is currently required from: Tarun Tuli, Angel Pons.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63969 )
Change subject: soc/intel/alderlake: provide a list of D-states to enter LPM
......................................................................
Patch Set 17:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/5554087d_e9d3e132
PS17, Line 1485: __weak uint8_t soc_lpi_get_constraints(void) { return 0; }
Another option is the weak implementation does the single device/dummy entry creation and that gets replaced with the more extensive one on the platform if it exists?
I like this one, moves the "default" logic to a now "default" place 👍
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63969
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe46a0583c522a8adf0a015cd3a698f694482437
Gerrit-Change-Number: 63969
Gerrit-PatchSet: 17
Gerrit-Owner: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 03 May 2022 19:13:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment